198028 - "Go" toolbar button should respect key modifiers (Shift/Ctrl/Alt)

Status: VERIFIED WORKSFORME

(Firefox :: Toolbars and Customization, enhancement)

Description

[David Tenser [:djst]]

When pressing Shift+Go, the url should open in a new window.

When pressing Ctrl+Go, the url should open in a new tab (background by default)

When pressing Shift+Ctrl+Go, the url should open in a new tab (foreground by
default)

Comment 1

[David Tenser [:djst]]

The background/foreground tab behavior could of course be debated, since Hyatt
seems to like not respecting that setting when Ctrl-clicking on a bookmark. But
personally, I'd rather make it consequent everywhere (e.g. ctrl+click should
open in background and shift+ctrl+click should open in foreground), including
bookmarks.

Comment 2

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 3

[Karl Guertin]

Related:
bug 197304
bug 187096 (?)

Comment 4

[Michael 'euphoria' Greene]

Middle click on Go should also cause the page to open in a new tab, which it
doesn't.

Comment 5

[David Tenser [:djst]]

The Go button is now consistent with the address bar keyboard modifiers.
Although this is better than not respecting key modifiers at all, it's not
consistent with the rest of the Firefox mouse shortcuts. Since Go is a toolbar
button, it should behave like the other toolbar buttons, e.g. Home or a bookmark
on the Bookmark Toolbar. The main reason here is because we're talking about
/mouse/ shortcuts, not /keyboard/ shortcuts.

To re-summarize:

* Shift+Go: open the url in a new window.
* Ctrl+Go: open the url in a new tab (background by default).
* Ctrl+Shift+Go: open the url in a new tab (foreground by
default).
* Alt+Go: save the url target.

Comment 6

[David Tenser [:djst]]

As a side-note, this would also make the Go button actually useful for a
specific scenario, when you want to save a file from the web to your hard drive,
and you only have the url, not a clickable link. 

For example, you want to save http://foo.bar/baz.txt. Normally, you would have
to enter the url in Firefox and hit Enter, which would display the file in this
case, since it's text/plain. Then you would select [File > Save Page As...] to
actually save the file. Or if you are on Linux, you would probably use wget instead.

Anyway, if this bug was fixed, you could just enter the url and hit Alt+Go to
automatically save the file, as if you Alt+clicked on a link. 

Comment 7

[:Gavin Sharp [email: [e-mail]]]

As David mentions, bug 206268 fixed this use the same handler as the URL bar, so
the same modifier behavior is observed.

Comment 8

[Phil Ringnalda (:philor)]

With a few-hours old trunk build:

Shift+Go opens a new window
Ctrl+Go opens a new foreground tab, by the same logic as bookmarks, that you're picking a single thing to look at, unlike links where you may well open dozens at once to look at later.
Ctrl+Shift+Go opens a new background tab
Alt+Go saves the URL.

I'd say you've been fixed, though somewhere else. If you really want to argue the foreground/background thing, that's grounds for a new bug.

Comment 9

[Phillip Stewart :P]

What about ctrl clicking and middle clicking?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Those work too.