1980487 - dialog-button custom element does not support passing params to SubDialogManager

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Emma Zühlcke [:emz]]

For bug 1971439 I'm trying to replicate the "clear data" button. privacy.js currently opens it via a call to gSubDialog (an instance of SubDialogManager). It passes parameters to the dialog via the last argument: https://searchfox.org/mozilla-central/rev/67c9592293e8d9f143e6053c8cfd6b7723207e3c/browser/components/preferences/privacy.js#2598-2600
These end up here: https://searchfox.org/mozilla-central/rev/67c9592293e8d9f143e6053c8cfd6b7723207e3c/toolkit/modules/SubDialog.sys.mjs#997

Passing these arguments is currently not supported in dialog-button. The dialog calls into SubDialogManager here: https://searchfox.org/mozilla-central/rev/67c9592293e8d9f143e6053c8cfd6b7723207e3c/browser/components/preferences/widgets/dialog-button/dialog-button.mjs#27 but does not pass in any additional arguments.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1980487 - Add support for passing additional dialog arguments in dialog-button element. r=#recomp-reviewers!

Comment 2

[Mark Kennedy [:mark]]

Updating severity to triage. Looks like there's already a patch in flight.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3a0f241fc66
https://hg.mozilla.org/integration/autoland/rev/dd3f4e7d33e0
Add support for passing additional dialog arguments in dialog-button element. r=reusable-components-reviewers,settings-reviewers,Gijs,hjones

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dd3f4e7d33e0