1980671 - Add tooltip to IP protection toolbar icon

Status: VERIFIED FIXED

(Firefox :: IP Protection, task)

Description

[Becca]

The IP Protection needs a conditional tooltip that displays different copy depending on the state of the VPN connection/toolbar icon.

ON:
"VPN on, open panel"
https://www.figma.com/design/l75lLbgf95PuVqNafzdvel/VPN---Firefox-Integration?node-id=11721-15670&m=dev

OFF:
"VPN off, open panel"
https://www.figma.com/design/l75lLbgf95PuVqNafzdvel/VPN---Firefox-Integration?node-id=11721-15682&m=dev

ERROR:
"VPN is disconnected"
https://www.figma.com/design/l75lLbgf95PuVqNafzdvel/VPN---Firefox-Integration?node-id=11721-15671&m=dev

Comment 1

[Becca]

Attachment: Bug 1980671 - Add tooltip to IP Protection toolbar icon - r=#ip-protection-reviewers!

Comment 2

[kpatenio]

Updated strings can be found in https://www.figma.com/design/l75lLbgf95PuVqNafzdvel/VPN---Firefox-Integration?node-id=9820-48889&p=f&m=dev.

Note that it only covers:

• "Firefox VPN" (default)
• "Turn on "Firefox VPN" (error occurs)

We have not added "Try Firefox VPN". We have a follow up task Bug 1984396 to address it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0957a58b778d
https://hg.mozilla.org/integration/autoland/rev/899b9d477c0c
Add tooltip to IP Protection toolbar icon - r=ip-protection-reviewers,fluent-reviewers,flod,fchasen

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/899b9d477c0c

Comment 5

[Valentina Virlics [:vvalentina], Ecosystem QA]

Just wanted 2 confirmations:

• regarding the error state - we change it from "VPN is disconnected" to "Turn Firefox VPN on"?
• for the ON/OFF states we show "Firefox VPN"?

Comment 6

[Fred Chasen [:fchasen]]

Attachment: Bug 1980671 - Add tooltip to IP Protection toolbar icon -

Original Revision: https://phabricator.services.mozilla.com/D259847

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/507ec6365e75
https://hg.mozilla.org/releases/mozilla-beta/rev/a4a5a3fee3b7

Comment 8

[kpatenio]

(In reply to Valentina Virlics [:vvalentina], Ecosystem QA from comment #5)

Just wanted 2 confirmations:

• regarding the error state - we change it from "VPN is disconnected" to "Turn Firefox VPN on"?
• for the ON/OFF states we show "Firefox VPN"?

Hi Valentina, yes that's correct.

Comment 9

[Valentina Virlics [:vvalentina], Ecosystem QA]

Based on above comments, we can mark this as verified-fixed on the latest Firefox Nightly 144.0a1 (25/08/24) and Firefox Beta 143.0b3, installed on Windows 10 x64, macOS 15.6.1.