1980787 - aspect-ratio breaks size containment

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[psychpsyo]

Attachment: contain-size-014.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:141.0) Gecko/20100101 Firefox/141.0

Steps to reproduce:

Specifying an aspect-ratio on an element with size containment (containerType: size) breaks the size containment.
I've already PRed a new web platform test for this here: https://github.com/web-platform-tests/wpt/pull/54107

Actual results:

The element now sizes to its children.

Expected results:

The element should be sized as if empty. (= it should be the specified aspect-ratio)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Thanks, I agree it's a bug.

Boris, ni? in case it's an easy fix :)

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

I have an idea to fix this.

Also, the upstream PR https://github.com/web-platform-tests/wpt/pull/54107 will be imported in Bug 1980709.

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1980787 - Apply aspect-ratio's auto content-based min block-size only when block-axis has no size containment. r?#layout

When the block-axis has size containment, the block-size can be determined
without considering the element's children. Therefore, aspect-ratio's automatic
content-based minimum sizes should not apply in this case.
https://drafts.csswg.org/css-sizing-4/#aspect-ratio-minimum

This behavior is aligned with blink and webkit.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f0270510e179
https://hg.mozilla.org/integration/autoland/rev/8024b8577a94
Apply aspect-ratio's auto content-based min block-size only when block-axis has no size containment. r=layout-reviewers,emilio

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8024b8577a94