1980800 - Update to 142 resets individual sort order of newsgroup folders

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Following the resolution of bug 251707, newsgroup folders can now be sorted in the same way as other folders. The sort order of these folders can be reset to alphabetical. Unfortunately, it has just become clear that the update to 142 Beta will reset the previously set individual sort order of all newsgroups, and all groups will be sorted alphabetically.

Apparently, several users who tested Beta 142 are very unhappy about this, as the recent discussion in the German newsgroup news:de.comm.software.mozilla.mailnews has shown.

To avoid upsetting many more users when 142 is released, I suggest implementing the migration code from the following patch, which should ensure that the previous sort order of newsgroup folders is maintained.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1980800 - Add migration code to maintain user sort order of newsgroup folders. r=#thunderbird-reviewers

Comment 2

[Alfred Peters [:infofrommozilla]]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #1)

Attachment 9504725 [details]

Works as intended.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0b67b5511410
Add migration code to maintain user sort order of newsgroup folders. r=babolivier

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9504725 [details]
Bug 1980800 - Add migration code to maintain user sort order of newsgroup folders. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Migration of custom sort order of newsgroup folders after bug 251707.
• User impact if declined: After updating to version 142, all newsgroup folders were sorted alphabetically, which evidently annoyed several Daily and Beta testers.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: Yes
• If yes, steps to reproduce: 1. Install 141.0b4.

2. Add a newsserver account (for example news.eternal-september.org, which doesn't require any registration for a subset of newsgroups).
3. Subscribe to several newsgroups.
4. Order them by drag and drop in some non-alphabetical order.
5. Update to a 142 Beta containing this fix.

All newsgroups should keep their custom sort order.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Migration code affects merely newsgroup folders, no other regressions are to be expected,
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: None

Comment 5

[Corey Bryant]

Comment on attachment 9504725 [details]
Bug 1980800 - Add migration code to maintain user sort order of newsgroup folders. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Corey Bryant]

Vlad/Ramona, can you test this once 142.0b3 is available as a candidate?

Comment 7

[Stephen King (:sking)]

Thunderbird 142.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/7bfc5502eb01