1980814 - Startup Crash in [@ OOM | large | NS_ABORT_OOM | nsMsgFilterList::LoadTextFilters]

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Wayne Mery (:wsmwk)]

Crash report: https://crash-stats.mozilla.org/report/index/7f0fa4f8-f427-4025-9fd3-cc5ef0250731

MOZ_CRASH Reason:

MOZ_CRASH(OOM)

Top 10 frames:

0  xul.dll  NS_ABORT_OOM(unsigned long long)  xpcom/base/nsDebugImpl.cpp:689
1  xul.dll  nsMsgFilterList::LoadTextFilters(already_AddRefed<nsIInputStream>)  mailnews/search/src/nsMsgFilterList.cpp:587
2  xul.dll  nsMsgFilterService::OpenFilterList(nsIFile*, nsIMsgFolder*, nsIMsgWindow*, ns...  mailnews/search/src/nsMsgFilterService.cpp:167
3  xul.dll  nsMsgIncomingServer::GetFilterList(nsIMsgWindow*, nsIMsgFilterList**)  mailnews/base/src/nsMsgIncomingServer.cpp:1073
4  xul.dll  XPTC__InvokebyIndex()  /builds/worker/workspace/obj-build/toolkit/library/build/Z:/builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/win32/xptcinvoke_asm_x86_64.asm:97
5  xul.dll  CallMethodHelper::Invoke()  js/xpconnect/src/XPCWrappedNative.cpp:1620
5  xul.dll  CallMethodHelper::Call()  js/xpconnect/src/XPCWrappedNative.cpp:1174
5  xul.dll  XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)  js/xpconnect/src/XPCWrappedNative.cpp:1120
6  xul.dll  XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*)  js/xpconnect/src/XPCWrappedNativeJSOps.cpp:966
7  xul.dll  CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::...  js/src/vm/Interpreter.cpp:501

Crash reports go back to version 102, but crash rate increased with version 139.

v139 https://crash-stats.mozilla.org/report/index/aca054ec-2490-4ed9-94e2-4b44c0250614
v128.5.2esr https://crash-stats.mozilla.org/report/index/51fb4a8f-2b39-4af5-b0a0-d66290250722

93% uptime <1 minute

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1980814 - Try to fix startup Crash in [@ OOM | large | NS_ABORT_OOM | nsMsgFilterList::LoadTextFilters]. r=#thunderbird-back-end-reviewers

Assuming garbled text file, where "name" not found, we'd end up with -1 translating to something huge as unsigned.

(Also, new is infallible since ages.)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29a6e9540ad7
Try to fix startup Crash in [@ OOM | large | NS_ABORT_OOM | nsMsgFilterList::LoadTextFilters]. r=tobyp

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9506341 [details]
Bug 1980814 - Try to fix startup Crash in [@ OOM | large | NS_ABORT_OOM | nsMsgFilterList::LoadTextFilters]. r=#thunderbird-back-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Crash fix
• User impact if declined: May crash
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: Yes
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple crash fix
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 4

[Corey Bryant]

Comment on attachment 9506341 [details]
Bug 1980814 - Try to fix startup Crash in [@ OOM | large | NS_ABORT_OOM | nsMsgFilterList::LoadTextFilters]. r=#thunderbird-back-end-reviewers

[Triage Comment]
Approved for esr140

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 140.3.0esr:
https://hg.mozilla.org/releases/comm-esr140/rev/4e143c8373d0c8a1498da29fceb34de8379297bd