198082 - AIX: GTK2 build fails (undefined symbol MAX_BUTTONS)

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Philip K. Warren]

When building embedding/browser/gtk/src:

rm -f libgtkembedmoz.so
/usr/vacpp/bin/makeC++SharedLib_r -ldl -p1 -brtl -bso -bsymbolic -bnortllib -o
libgtkembedmoz.so  gtkmozembedmarshal.o gtkmozembed2.o EmbedPrivate.o
EmbedWindow.o EmbedProgress.o EmbedContentListener.o EmbedEventListener.o
EmbedWindowCreator.o EmbedStream.o EmbedPrompter.o GtkPromptService.o    -brtl
-bso -bh:5    ../../../../dist/lib/libembed_base_s.a
../../../../dist/lib/libprofdirserviceprovider_s.a   -L../../../../dist/bin
-lxpcom  -liconv -L../../../../dist/bin
-L/home/pkw/builds/trunk/mozilla/obj-gtk2-opt/dist/lib -lplds4 -lplc4 -lnspr4
-lpthreads    -L/opt/freeware/gnome/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0
-lgdk_pixbuf-2.0 -lm -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0
-lglib-2.0 -lintl -liconv   -lC_r -ldl -lm -lc_r    
ld: 0711-317 ERROR: Undefined symbol: EmbedPrompter::MAX_BUTTONS

Comment 1

[Philip K. Warren]

Attachment: Patch v1

MAX_BUTTONS is currently defined as "static const int MAX_BUTTONS = 3". This
does not compile on the AIX compiler as currently written. There are three
alternative ways to declare this so it will compile:

1) Change it to a #define - what I did in this patch.
2) Change it to an enum.
3) Initialize EmbedPrompter::MAX_BUTTONS after the class declaration.

Comment 2

[Philip K. Warren]

Reassigning to me.

Comment 3

[Christopher Blizzard (:blizzard)]

Comment on attachment 117635 [details] [diff] [review]
Patch v1

sr=blizzard

Comment 4

[Philip K. Warren]

Fixed.

Checking in EmbedPrompter.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.cpp,v  <-- 
EmbedPrompter.cpp
new revision: 1.6; previous revision: 1.5
done
Checking in EmbedPrompter.h;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.h,v  <--  EmbedPrompter.h
new revision: 1.4; previous revision: 1.3
done