Closed Bug 1981139 Opened 1 year ago Closed 7 months ago

Fix ruff warnings in dom/bindings/parser

Categories

(Core :: DOM: Bindings (WebIDL), task)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: damia.vergnet, Assigned: damia.vergnet)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Output of ./mach lint -W -l ruff .:

dom/bindings/parser/runtests.py
   29:19  warning  Use format specifiers instead of percent format  UP031 (ruff)
   33:19  warning  Use format specifiers instead of percent format  UP031 (ruff)
   39:19  warning  Use format specifiers instead of percent format  UP031 (ruff)
   44:15  warning  Use format specifiers instead of percent format  UP031 (ruff)
   56:34  warning  Use format specifiers instead of percent format  UP031 (ruff)
   67:24  warning  Use format specifiers instead of percent format  UP031 (ruff)
   88:31  warning  Use format specifiers instead of percent format  UP031 (ruff)
   99:15  warning  Use format specifiers instead of percent format  UP031 (ruff)
  100:15  warning  Use format specifiers instead of percent format  UP031 (ruff)
  102:19  warning  Use format specifiers instead of percent format  UP031 (ruff)
  104:23  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_attr.py
  108:44  warning  Use format specifiers instead of percent format  UP031 (ruff)
  128:44  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_attributes_on_types.py
  371:31  warning  Use format specifiers instead of percent format  UP031 (ruff)
  380:31  warning  Use format specifiers instead of percent format  UP031 (ruff)
  453:17  warning  Use format specifiers instead of percent format  UP031 (ruff)
  462:27  warning  Use format specifiers instead of percent format  UP031 (ruff)
  468:17  warning  Use format specifiers instead of percent format  UP031 (ruff)
  477:27  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_callback.py
  25:42  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_callback_constructor.py
  29:42  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_callback_interface.py
  104:13  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_cereactions.py
  53:13  warning  Use format specifiers instead of percent format  UP031 (ruff)
  73:13  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_const.py
  64:44  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_error_lineno.py
  25:13  warning  Use format specifiers instead of percent format  UP031 (ruff)

dom/bindings/parser/tests/test_float_types.py
  59:36  warning  Use format specifiers instead of percent format  UP031 (ruff)
  63:13  warning  Use format specifiers instead of percent format  UP031 (ruff)

Warnings from dom/bindings/parser/tests/test_distinguishability.py have already been patched in Bug #1979846.

Blocks: ruff
Component: Lint and Formatting → DOM: Bindings (WebIDL)
Product: Developer Infrastructure → Core
Assignee: nobody → damia.vergnet
Attachment #9505154 - Attachment description: WIP: Bug 1981139 - ruff: fix warnings about %-formatted strings in dom/bindings/parser → Bug 1981139 - ruff: fix warnings about %-formatted strings in dom/bindings/parser. r=sylvestre
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:damia.vergnet, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(sledru)
Flags: needinfo?(damia.vergnet)

Damia, don't hesitate to ping us to land code!

Flags: needinfo?(sledru)
Flags: needinfo?(damia.vergnet)
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch

(In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Damia, don't hesitate to ping us to land code!

Hi, I haven’t looked at it in a while, but iirc it should be all good. Cheers.

QA Whiteboard: [qa-triage-done-c152/b151]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: