Open Bug 1981527 Opened 1 year ago Updated 1 year ago

Small PiP size/area can result in truncated or impossible to read tooltips

Categories

(Toolkit :: Picture-in-Picture, defect, P3)

Firefox 140
defect

Tracking

()

People

(Reporter: clement.lefevre, Unassigned)

References

Details

Attachments

(4 files)

PiP tooltips when hovering buttons are always placed relatively to those buttons in some way that doesn't consider PiP's size and seems to be restricted to the PiP surface.

The direct result is that when the PiP's size/area is too small, tooltip is truncated and can even become impossible to read.

It should be possible for it to overflow it's PiP's area or at least check the available area and move it in a way that make it still possible to read when the area is small.

EDIT: Issue encountered on mac and Linux with Wayland, but I wouldn't be surprised if every OS would be affected.

Can you attach a screenshot of the issue?
Thanks.

Flags: needinfo?(clement.lefevre)

Sure. Here's a first, the smallest PiP Firefox allowed me to have on Linux/Wayland.

Flags: needinfo?(clement.lefevre)

The smallest I could get on mac (different display resolution though), which is small to a point it'd anyway be hard to manage, but even the buttons are misplaced in this case.

And this one and next one on a little bit bigger sizes so that we get tooltips but they gets truncated as described.

I guess we hit a bit corner case here. Is there any issue you see with regularly sized PIP?

Flags: needinfo?(clement.lefevre)

(In reply to Martin Stránský [:stransky] (ni? me) from comment #6)

I guess we hit a bit corner case here. Is there any issue you see with regularly sized PIP?

Well… it depends on your definition of "regularly-sized". I discovered it at first when sizing it to a size I wanted to use (eg. mostly listening but sometimes having a rough picture of a stream/video you're looking to, putting it in a corner, not too visible nor annoying to use what I have on screen in the context of work/job.

Only after I discovered the issue, I tried to push it to the limit for this bug report (maybe I didn't even tried to reduce it to the maximum before your NI:)

Especially, the first time I've hit the issue, it seemed like the surface of the PiP area was clearly big enough to fit the tooltip if it wasn't always positioned in the same way relatively to the buttons, and therefore it needs to check if positioned to its default place it would be truncated and if yes position it differently. If there's room for it, obviously. The smallest cases I posted as screenshot #1 and 2 wouldn't allow for this.

This is of course a very minor issue, a little annoyance when interacting with it and making look slightly less polished.

Flags: needinfo?(clement.lefevre)

We may consider to enable move-to-rect tooltips for PIP windows on Wayland. Not sure about MacOS.

Emilo, what do you think? I don't have strong opinion here.
Thanks.

Flags: needinfo?(emilio)
Priority: -- → P5

Also, I'd say this is some mechanics that already exist for Firefox within the webpages themselves, I just did a little test and it place it in a different manner if we're close to borders and it'd end up truncated.

(I don't know what's move-to-rect, but this is probably normal!)

move-to-rect is Wayland system driven popup window placement we want to avoid at all cost.

See Also: → 1941237

(In reply to Martin Stránský [:stransky] (ni? me) from comment #10)

move-to-rect is Wayland system driven popup window placement we want to avoid at all cost.

Why, is there something absolutely terrible about it that makes it unfit?

Well, we could if those were real tooltips. However they are not, so this is kind of on the front-end to fix I think.

If they want to show real tooltips, then it's likely that this will still not work on Wayland. We can fix it then tho :)

Component: Widget: Gtk → Picture-in-Picture
Flags: needinfo?(emilio)
Product: Core → Toolkit
Priority: P5 → --
Severity: -- → S4
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: