1981745 - Make `in_gecko` Cargo feature optional in moz-central

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Ben Dean-Kawamura [:bdk]]

This feature makes it so we avoid linking our Rust libs/binaries against libsqlite (it doesn't link against either the vendored or system lib). This is what we want for a real build, since we eventually want to link against the libmozsqlite that exists in the install directory. However, this is not what we want for the tests and prevents them from being built.

Implementing this is an alternative to https://bugzilla.mozilla.org/show_bug.cgi?id=1958000, if we can make Cargo do the linking then we don't need to do anything special with mach rusttests.

Comment 1

[Ben Dean-Kawamura [:bdk]]

Attachment: Bug 1981745 - Make the `in_gecko` feature optional, r=glandium

This makes it possible to build Rust stuff that depends on rusqlite
and link to the vendored libsqlite. For example cargo test -p relevancy now works because of this. This will become more important
when we move the app-services code into moz-central.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ecb0fe0be335
https://hg.mozilla.org/integration/autoland/rev/837387967539
Make the `in_gecko` feature optional, r=glandium

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/837387967539