1981968 - moz-input-{text,search} value attribute is a bit footgunny.

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

MozInputText and subclasses use a public value member to track the current input value:

https://searchfox.org/mozilla-central/rev/202069c4c5113a1a9052d84fa4679d4c1b22113e/toolkit/content/widgets/moz-input-text/moz-input-text.mjs#31,43

Instead of forwarding to the real input. That causes code like input.value = "foo" from an external consumer to not behave as expected. It changes the internal state of MozInputText, but it doesn't get reflected in the <input> element.

Comment 1

[Tim Giles [:tgiles] | OOO Dec 19 - Jan 6]

The issue is caused by not using .value here: https://searchfox.org/mozilla-central/rev/b3386c22cefca2225cf190522b1862c12765d1ba/toolkit/content/widgets/moz-input-text/moz-input-text.mjs#54

Could be prevented in the future by using: https://github.com/43081j/eslint-plugin-lit/blob/master/docs/rules/no-value-attribute.md

:hjones, here's that needinfo you requested for creating a bug for the eslint no value attribute rule.

Comment 2

[Tim Giles [:tgiles] | OOO Dec 19 - Jan 6]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug. You will need to update line 56 in moz-input-text.mjs so that it reads .value instead of value.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me by using the "Request information from" checkbox and setting the dropdown select to "mentor". Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with ./mach build and test your change with ./mach test toolkit/content/tests/widgets/ --headless. Also check your changes for adherence to our style guidelines by using ./mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 3

[mlucks]

Attachment: Bug 1981968 - Property bind the value attribute. r=kpatenio,tgiles,mstriemer

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b4f178aea315
https://hg.mozilla.org/integration/autoland/rev/ab046d83af4a
Property bind the value attribute. r=tgiles

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ab046d83af4a