1981925 - The searched string is not cleared after using Show in folder context menu option inside the Library

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 22 Dec-9 Jan, please ni? :mboldan]]

• This is only a follow-up since this was initially found by Alice in bug 1979434

Found in

• 142.0b8

Affected versions

• 142.0b8
• 143.0a1 (2025-08-08)
• 141.0.3

Tested platforms

• Affected platforms: Ubuntu 24, Windows 10, macOS 12
• Unaffected platforms: none

Steps to reproduce:

1. Open Library
2. Type search term (e.g., f) in Search field and hit [ENTER]
3. Right-click on a search result
4. Choose Show in folder
5. Click on the Search field to focus
6. Hit [ENTER]

Actual result:

• Nothing happens

Expected result:

• Clear search term at step 4 like previous version.

Regression window:

• https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=48d34ac93eaf2fbe0e36bc934af2bb1a85f508e6&tochange=263bab4209ad7a516863be36705adb00b967f85c

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1967209, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1981925 - Use input.clear() for places searchbox. r=#places-reviewers

That gets the right behavior. I filed bug 1981968 because this seems a
bit footgunny to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9a188d883f23
https://hg.mozilla.org/integration/autoland/rev/7efd7a0fece7
Use input.clear() for places searchbox. r=places-reviewers,Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b8a9b3dbbc76
https://hg.mozilla.org/integration/autoland/rev/b7483c08e439
Revert "Bug 1981925 - Use input.clear() for places searchbox. r=places-reviewers,Standard8" for causing build bustages.

Comment 5

[agoloman]

Backed out for causing build bustages.

• Backout link
• Push with failures
• Failure Log

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Could you reland? Fairly sure it's not the culprit

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5fe4e0c7648a
https://hg.mozilla.org/integration/autoland/rev/afbf63802fd1
Use input.clear() for places searchbox. r=places-reviewers,Standard8

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/afbf63802fd1

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9505963 [details]
Bug 1981925 - Use input.clear() for places searchbox. r=#places-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: One-liner
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner.
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9505963 [details]
Bug 1981925 - Use input.clear() for places searchbox. r=#places-reviewers

We are in RC week and out of betas so moving request to release for the next dot release or a re-spin if possible.

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 22 Dec-9 Jan, please ni? :mboldan]]

Verified fixed with Firefox 143.0a1 (2025-08-13) on Windows 10x64, macOS 15 and Ubuntu 24 using steps from comment 0.

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9505963 [details]
Bug 1981925 - Use input.clear() for places searchbox. r=#places-reviewers

Approved for 142.0.1

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/812a8d9392b2
https://hg.mozilla.org/releases/mozilla-release/rev/a2452f736393

Comment 15

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue with an affected Firefox Nightly 143.01 build from 2025-08-07 on macOS 14, as described in Comment 0.
Verified as fixed using Firefox 142.0.1-build1 on macOS 14, Windows 11 and Ubuntu 22.04.