1982431 - extensions.webextensions.warnings-as-errors is reported as changed - should be using ExtensionTestUtils.failOnSchemaWarnings() instead

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Magnus Melin [:mkmelin]]

Per bug 1977567 comment 6:
Here is an example of a bug revealed by the change: The extensions.webextensions.warnings-as-errors is reported as changed. This pref is set by default in tests to enable stricter extension schema validation checks (e.g. use of deprecated or misspelled properties in manifest.json). If the pref were to be turned off, then this stricter validation would be disabled for all unrelated tests that follow.

There are three files listing these, at https://bug1977567.bmoattachments.org/attachment.cgi?id=9500923#pref-extensions.webextensions.warnings-as-errors . These manually set the preferences and clear them afterwards (e.g. browser_ext_commands_execute_browser_action.js). In this specific case, ExtensionTestUtils.failOnSchemaWarnings(false); should be used instead (examples of uses in m-c: https://searchfox.org/mozilla-central/search?q=ExtensionTestUtils.failOnSchemaWarnings&path=browser%2F&case=false&regexp=false ). This advice applies to all of the tests that manually touch the pref, at https://searchfox.org/comm-central/search?q=extensions.webextensions.warnings-as-errors&path=mail%2F&case=true&regexp=false

Comment 1

[John Bieling]

Thanks Magnus for reporting this!

Comment 2

[John Bieling]

Attachment: Bug 1982431 - Use ExtensionTestUtils.failOnSchemaWarnings() instead of changing the prefs directly. r=mkmelin

This patch also restores the the extensions.webextensions.uuids preference.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/40773461c8e2
Use ExtensionTestUtils.failOnSchemaWarnings() instead of changing the prefs directly. r=mkmelin