1982843 - [Intermittent] Clicking the market suggestion doesn’t redirect to the specific’s stock search engine results page

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: market result no action.mp4

[Affected versions]:

• Firefox Nightly 143.0a1 (Build ID: 20250813091044)

[Affected Platforms]:

• Windows 11 x64
• Ubuntu 24.04 x64
• macOS 15.3

[Prerequisites]:

• Have a Firefox Nightly 143 installed.
• Be connected to a “US” server using a VPN client.
• Set the following prefs with the next values:
  -> browser.search.region = US
  -> browser.urlbar.quicksuggest.enabled = true
  -> browser.urlbar.suggest.realtimeOptIn = true
  -> browser.urlbar.quicksuggest.dynamicSuggestionTypes = realtime_opt_in
  -> browser.urlbar.quicksuggest.dataCollection.enabled = false
  -> browser.urlbar.merino.timeoutMs = 2000
• Using the RS addon, change the environment to Stage and restart the browser.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Focus the Address Bar.
3. Type a market specific keyword (e.g.: stocks, shares, s and p, netflix stock, etc.).
4. Click the “Show suggestions” button.
5. Type a market specific keyword (e.g. apple stock, tesla stock, visa stock etc).
6. Click the market suggestion.
7. Observe the behavior.

[Expected result]:

• The serp page for the specific stock is loaded.

[Actual result]:

• The serp page is not loaded.

[Notes]:

• This issue is difficult to reproduce as we encountered it only a few times since we started testing the feature.
• Attached is a screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

I was able to reproduce this:

1. Enable online suggestions
2. In a new tab, type "aapl" and click the stock suggestion
3. Go back
4. Verify "AAPL stock" is in the urlbar input
5. Click in the urlbar ("AAPL stock" will be selected) and type "aapl" again and click the stock suggestion

There's an error thrown related to persisted search terms here because this.window.gBrowser.selectedBrowser.originalURI is null:

NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIURI.equals]
    #handlePersistedSearchTerms resource:///modules/UrlbarInput.sys.mjs:3903
    setURI resource:///modules/UrlbarInput.sys.mjs:444
    onLocationChange chrome://browser/content/browser.js:2204
    callListeners chrome://browser/content/tabbrowser/tabbrowser.js:1017
    _callProgressListeners chrome://browser/content/tabbrowser/tabbrowser.js:1031
    _callProgressListeners chrome://browser/content/tabbrowser/tabbrowser.js:8002
    onLocationChange chrome://browser/content/tabbrowser/tabbrowser.js:8477

That code was introduced in bug 1976102.

I don't know if this a problem specific to market suggestions or if other result types can hit it too. I can't reproduce it by repeating the STR with search suggestions instead of a market suggestion.

Comment 2

[Drew Willcoxon :adw]

Bug 1984214 fixed this. I can't reproduce this with https://hg-edge.mozilla.org/mozilla-central/rev/19a73c5a5e48, but I can with its parent, https://hg-edge.mozilla.org/mozilla-central/rev/b32bb83e70081bda9f409cf9e582c776c7999a41.

Comment 3

[Carmen Fat [:cfat] - Ecosystem QA]

• We didn't encounter this issue anymore during the Beta preliminary testing phase, so I think it's safe to mark this report as Verified Fixed.

Testing was conducted on the latest Firefox Nightly 144.0a1 (Build ID: 20250826095322) and Beta 143.0b5 (Build ID: 20250827090822) on Windows 11, macOS 15.3, and Ubuntu 24.04 x64.