1984214 - Selecting a market result with the keyboard blanks out the input

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

Selecting a market result with keyboard blanks out the urlbar input. The input should show the query that will be performed when you hit Enter. if you then hit Enter, nothing happens.

Comment 1

[Drew Willcoxon :adw]

I can't reproduce this now. The input is blanked out, but pressing Enter does search for the right query. I could have sworn nothing happened. Maybe I had my own WIP applied that messed it up.

I already wrote a patch that makes some other changes, so I'll go ahead and post it anyway.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1984214 - Update the urlbar input when a market result is selected.

DYNAMIC results can already define payload.input in order to tell
UrlbarInput the value that should be set in the input when the result is
selected [1]. We can't use that here because market results can have many items
that all have their own query.

So this patch lets DYNAMIC results also set element.dataset.query on their
child elements, and it modifies the code at [1] so that it checks the query
defined on the element. I had to modify the related code paths so that the
selected element is passed in.

Since I was doing that, I thought it also made sense to hook up
element.dataset.query to the URL-loading path in UrlbarInput.pickElement().
Now DYNAMIC results can define payload.engine and either payload.query or
element.dataset.query, and UrlbarInput will automatically load the
appropriate search URL, just like it does for SEARCH results.

This also makes some other improvements:

• Incorporate dataset into the UrlbarView method that updates an element in
  a DYNAMIC row (renamed from #setDynamicAttributes() to
  #updateElementForDynamicType())

• I moved some things from MarketSuggestion.getViewTemplate() to
  getViewUpdate() because the intended purpose of getViewTemplate() (and
  view templates generally) is that they are only the DOM structure without any
  "interior" data that depends on a given UrlbarResult. Really the only reason
  that getViewTemplate() exists at all is to support DOM structures with a
  variable number of children.

• In the MarketSuggestions view template, I renamed item to item_${i}
  because names should be unique within a view template.

[1] https://searchfox.org/firefox-main/rev/d683b2b2ed86192b3a87150c21fc51ba02a93142/browser/components/urlbar/UrlbarInput.sys.mjs#2655

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2f6b6712c21b
https://hg.mozilla.org/integration/autoland/rev/19a73c5a5e48
Update the urlbar input when a market result is selected. r=daisuke

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/19a73c5a5e48

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9508373 [details]
Bug 1984214 - Update the urlbar input when a market result is selected.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This is required for the "carrots" realtime-suggestions Suggest feature in 143.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a little higher risk than the other "carrots" uplifts I've been requesting because it modifies general urlbar code and not only code specific to the carrots feature, but the changes are still relatively small and the urlbar test suite is extensive.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Drew Willcoxon :adw]

Actually this should be QA verified.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9508373 [details]
Bug 1984214 - Update the urlbar input when a market result is selected.

Approved for 143.0b4.

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/1d63ecfe281b
https://hg.mozilla.org/releases/mozilla-beta/rev/9af4d085277a

Comment 9

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 144.0a1 (Build ID: 20250825091413) on Windows 11, macOS 15.3, and Ubuntu 24.04 x64.

• The urlbar shows the market keyword in the “<TICKER> stock” format when focusing the market suggestion.
• The “<TICKER> stock” string is still displayed in the urlbar after selecting the market suggestion using keyboard navigation and the SERP is displayed.

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Beta 143.0b4 (Build ID: 20250825091315) on Windows 11, macOS 15.3, and Ubuntu 24.04 x64.

• The urlbar shows the market keyword in the “<TICKER> stock” format when focusing the market suggestion.
• The “<TICKER> stock” string is still displayed in the urlbar after selecting the market suggestion using keyboard navigation and the SERP is displayed.