1982964 - Update moz-box-* elements so they can handle wrappers between the group and children

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Mark Striemer [:mstriemer]]

In SRD 2025 we're going to want to have setting-control wrappers around moz-box-items (of any variety). This unfortunately breaks the styling since the box-group is trying to override the styling of immediate children, and the box item is no longer the immediate child.

Find a way to get the styling to continue to work, it can be a little hacky, using a @container style() query seems like it would be pretty clean, but unfortunately we don't support that right now.

/* Example code for some follow up later maybe? Doesn't work in 143 */
/* moz-box-common.css */
:host {
    @container style(--box-type: middle) or style(--box-type: last) {
      --box-border-radius-start: 0;
    }
    @container style(--box-type: first) or style(--box-type: middle) {
      --box-border-radius-end: 0;
      --box-border-width-end: 0;
    }
}

/* moz-box-group.css */
::slotted(*) {
  --box-type: middle;
}
::slotted(*:first-child) {
  --box-type: first;
}
::slotted(*:last-child) {
  --box-type: last;
}

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1982964 - Part 1: Handle slotting non-MozBaseInput elements in config-based settings r?#recomp-reviewers!

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1982964 - Part 2: update moz-box-group to handle hidden elements and non-moz-box-* elements r=#recomp-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4e56e93dca55
https://hg.mozilla.org/integration/autoland/rev/3538d541aa1f
Part 1: Handle slotting non-MozBaseInput elements in config-based settings r=tgiles
https://github.com/mozilla-firefox/firefox/commit/fc8112251e54
https://hg.mozilla.org/integration/autoland/rev/1b3103d6f570
Part 2: update moz-box-group to handle hidden elements and non-moz-box-* elements r=desktop-theme-reviewers,jules,mstriemer

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3538d541aa1f
https://hg.mozilla.org/mozilla-central/rev/1b3103d6f570