1983020 - Win 10 before build 17134 fails to start with api-ms-win-core-console-l1-2-0.dll is missing message.

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Bob Owen (:bobowen)]

There is still an LTS build (14393) before this build, which has long term support until October 13, 2026.
Setting to S3, as only Nightly and limited to old Windows builds.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1937025

Comment 2

[Bob Owen (:bobowen)]

[Tracking Requested - why for this release]:
Affects still in support windows LTS build.

Comment 3

[Bob Owen (:bobowen)]

Attachment: Bug 1983020: Remove LiveTicksNowIgnoringOverride to prevent mincore dependency. r=gstoll!

This also replaces the use of mincore lib with userenv for app container calls.

Comment 4

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/jobs?repo=try&revision=54162763fcc65bc0ef66b99dd5ead016a6cd325a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f3b91bfd2072
https://hg.mozilla.org/integration/autoland/rev/d67fc3a91755
Remove LiveTicksNowIgnoringOverride to prevent mincore dependency. r=gstoll

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d67fc3a91755

Comment 7

[Yannis Juglaret [:yannis]]

:bobowen pinged me to double-check if this issue may affect updater.exe, because since the landing of bug 1950060 we have chromium code running in updater.exe as well. I was able to reproduce the firefox.exe issue (so I was using the correct Windows version), but in the latest Nightlies updating with updater.exe worked just fine.

Looking closer at what's happening, firefox.exe imports AttachConsole to be able to perform a call to mozilla::UseParentConsole in the launcher process (mozilla::LauncherMain). In faulty builds of firefox.exe, we are importing AttachConsole through api-ms-win-core-console-l1-2-0.dll, while in working builds we are importing it from KERNEL32.dll (as shown by dumpbin /imports firefox.exe).

It seems that the problem was caused by linking with mincore.lib because mincore.lib and kernel32.lib both provide AttachConsole but through a different DLL, and in the faulty builds the version provided by mincore.lib took precedence over the one from kernel32.lib.

updater.exe doesn't import AttachConsole, which seems to be the specific function that caused trouble here. However, we do use mincore.lib in our Library("zucchini"), and it could take precedence for other functions. Given the issue we ran into here, it feels like it would be wise to remove the dependency on mincore.lib in zucchini as well even though we don't appear to have a problem right now.