1983370 - Using cursor key to select messages from the search bar skips every other message

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Ed]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:141.0) Gecko/20100101 Firefox/141.0

Steps to reproduce:

• typed a search term in the Search bar

• pressed the cursor-down key a few times

Actual results:

The second message is focused, then when continuing to cursor down, every other message is focused.

Expected results:

When repeatedly pressing cursor-down, the first and every subsequent message should be focused.

Comment 1

[Ed]

See https://www.reddit.com/r/Thunderbird/comments/1mpwuub/using_arrow_keys_to_select_emails_from_search_bar/.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Regression window

Backing out https://hg-edge.mozilla.org/comm-central/rev/a8ddf126cb9b972008354e0def4c2f4d47553ffe fixes this.

Comment 3

[Martin Giger [:freaktechnik]]

Ah right, we would no longer need to add this listener most likely: https://searchfox.org/comm-central/rev/6308d1c5c2ac49dee57d0eef11128aea0d8529fc/mail/components/unifiedtoolbar/content/items/global-search-bar.mjs#91-93 since the parent element now adds it.

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1983370 - Fix up/down keys in global search bar. r=freaktechnik

See https://bugzilla.mozilla.org/show_bug.cgi?id=1983370#c3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/846c106bc3f5
Fix up/down keys in global search bar. r=freaktechnik

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9510024 [details]
Bug 1983370 - Fix up/down keys in global search bar. r=freaktechnik

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Recent regression.
• User impact if declined: When user tries to select a search result from the global search bar with the up/down arrow keys, every other result is skipped.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Extremely simple change (key event listener was added twice), no risk.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: None.

Comment 7

[Corey Bryant]

Comment on attachment 9510024 [details]
Bug 1983370 - Fix up/down keys in global search bar. r=freaktechnik

[Triage Comment]
Approved for beta