1983934 - Centralize Maven repository configuration

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, task)

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1983934 - Centralize Maven repository configuration via `dependencyResolutionManagement` in `SettingsPlugin` r?nalexander

Comment 2

[Phabricator Automation]

Comment on attachment 9507969 [details]
Bug 1983934 - Centralize Maven repository configuration via dependencyResolutionManagement in SettingsPlugin r?nalexander

Revision D261617 was moved to bug 2007013. Setting attachment 9507969 [details] to obsolete.

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1983934 - Add gradle.configureMavenRepositories to de-duplicate repository configuration r?nalexander

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3aebd1c22e92
https://hg.mozilla.org/integration/autoland/rev/3acf573e6b94
Centralize Maven repository configuration via `dependencyResolutionManagement` in `SettingsPlugin` r=nalexander,android-reviewers,geckoview-reviewers

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3acf573e6b94

Comment 6

[Ben Dean-Kawamura [:bdk]]

This breaks app-services auto-publish for me.

I see a bunch of warnings like this:

> Configure project :components:feature-fxsuggest
  Build was configured to prefer settings repositories over project repositories but repository 'MavenRepo' was added by plugin 'com.jetbrains.python.envs'

Followed by a bunch of errors like this:

  > Configure project :geckoview
  GeckoView version = 150.0.20260224112257-SNAPSHOT
  [gradle:error]: > Could not determine the dependencies of task ':fenix:compileDebugJavaWithJavac'.
  [gradle:error]: > > Could not determine the dependencies of task ':fenix:compileDebugJavaWithJavac'.
  [gradle:error]: >   > Could not resolve all dependencies for configuration ':fenix:debugCompileClasspath'.
  [gradle:error]: >     > Could not resolve all dependencies for configuration ':fenix:debugCompileClasspath'.
  [gradle:error]: >       > Could not find any version that matches org.mozilla.appservices:syncmanager:0.0.1-SNAPSHOT-+.
  [gradle:error]: >         Versions that do not match:
  [gradle:error]: >           - 63.0.0
  [gradle:error]: >           - 62.1.0
  [gradle:error]: >           - 62.0.0
  [gradle:error]: >           - 61.0.13
  [gradle:error]: >           - 61.0.12
  [gradle:error]: >           - + 53 more
  [gradle:error]: >         Required by:
  [gradle:error]: >             project ':fenix'
  [gradle:error]: >

Is there any extra configuration I can add to avoid this issue? If not, what changes are needed to make this work again?

Comment 7

[Ben Dean-Kawamura [:bdk]]

Adding mavenLocal() to the repositories section in SettingsPlugin.kt fixes things for me, so I can unblock myself for the short term. Long-term, maybe there's a way to make that conditional on the localProperties.autoPublish.application-services.dir property?