2007013 - Consolidate duplicated Gradle configuration into `Settings` and `Project` plugins

Status: REOPENED

(Firefox Build System :: Android Studio and Gradle Integration, task)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

This will de-duplicate a lot of code.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Refactor `DependenciesPlugin` into `MozillaSettingsPlugin` with separate component files r?nalexander

• Also renamed plugins/dependencies to plugins/settings

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Rename `ConfigPlugin` to `MozillaProjectPlugin` and move to `plugins/project` r?nalexander

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate `local.properties` loading into `MozillaSettingsPlugin` r?nalexander

Comment 4

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate A-C test/lint disabling into `SettingsPlugin` and `ProjectPlugin r?nalexander

Comment 5

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate Kotlin compiler message reformatter into `ProjectPlugin` r?nalexander

Comment 6

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Add gradle.configureMavenRepositories to de-duplicate repository configuration r?nalexander

Comment 7

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: WIP: Bug 2007013 - Centralize Maven repository configuration via dependencyResolutionManagement r?nalexander

Comment 8

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate Kotlin `allWarningsAsErrors` configuration into `ProjectPlugin` r?nalexander

Comment 9

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate utility tasks (`clean`, `listRepositories`) into `MozillaProjectPlugin` r?nalexander

Comment 10

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate `buildToolsVersion` configuration into `ProjectPlugin` r?nalexander

Comment 11

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate `jvmToolchain` configuration into `ProjectPlugin` r?nalexander

Comment 12

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate Glean version resolution into `ProjectPlugin` r?nalexander

Comment 13

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate ktlint configuration into `ProjectPlugin` r?nalexander

Comment 14

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Remove redundant `Detekt` exclusions in Fenix `build.gradle` r?nalexander

Comment 15

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Migrate `shared-settings.gradle` to `MozillaSettingsPlugin` r?nalexander

Comment 16

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Move `getBuildId` into conventions plugin and cache result r?nalexander

Comment 17

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate test output formatting into `ProjectPlugin` r?nalexander

Comment 18

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate `printVariants` task into `ProjectPlugin` r?nalexander

Comment 19

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate `packaging.resources.excludes` into `ProjectPlugin` r?nalexander

Comment 20

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Remove unused GeckoView dependency substitution r?nalexander

Comment 21

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Consolidate OSS licenses plugin fix into `ProjectPlugin` r?nalexander

Comment 22

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Migrate `autopublish-settings.gradle` to `SettingsPlugin` and `ProjectPlugin r?nalexander

Comment 23

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Centralize Maven repository configuration via `dependencyResolutionManagement` in `SettingsPlugin` r?nalexander

Comment 24

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Add initial scaffolding for `ProjectPlugin` and `SettingsPlugin` r?nalexander

Comment 25

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Remove unused `DependenciesPlugin` dependency from `publicsuffixlist` plugin to fix classloader issue with `BuildMetricsService` r?nalexander

Comment 26

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Replace `topobjdir` from `mozconfig` with explicit `outputDir` property in `BuildMetricsService` r?nalexander

Comment 27

[Phabricator Automation]

Comment on attachment 9534068 [details]
Bug 2007013 - Add gradle.configureMavenRepositories to de-duplicate repository configuration r?nalexander

Revision D277089 was moved to bug 1983934. Setting attachment 9534068 [details] to obsolete.

Comment 28

[Phabricator Automation]

Comment on attachment 9534132 [details]
Bug 2007013 - Centralize Maven repository configuration via dependencyResolutionManagement in SettingsPlugin r?nalexander

Revision D261617 was moved to bug 1983934. Setting attachment 9534132 [details] to obsolete.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f72b421b9b09
https://hg.mozilla.org/integration/autoland/rev/9f4ff48ddabd
Add initial scaffolding for `ProjectPlugin` and `SettingsPlugin` r=nalexander,geckoview-reviewers,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/422f32e7696e
https://hg.mozilla.org/integration/autoland/rev/1e902cafcd85
Remove unused `DependenciesPlugin` dependency from `publicsuffixlist` plugin to fix classloader issue with `BuildMetricsService` r=nalexander,geckoview-reviewers,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/f119d5ccf722
https://hg.mozilla.org/integration/autoland/rev/2c6e368bcc86
Replace `topobjdir` from `mozconfig` with explicit `outputDir` property in `BuildMetricsService` r=nalexander,android-reviewers

Comment 30

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9f4ff48ddabd
https://hg.mozilla.org/mozilla-central/rev/1e902cafcd85
https://hg.mozilla.org/mozilla-central/rev/2c6e368bcc86

Comment 31

[Takanori MATSUURA]

Reopened for unpublished changesets.

Comment 32

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Add `isTruthy()` utility to `conventions` plugin r?nalexander

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/513a8209f0c2
https://hg.mozilla.org/integration/autoland/rev/8c2d75af597a
Add `isTruthy()` utility to `conventions` plugin r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/076489178857
https://hg.mozilla.org/integration/autoland/rev/c921785e9cf1
Migrate `autopublish-settings.gradle` to `SettingsPlugin` and `ProjectPlugin r=nalexander,geckoview-reviewers,android-reviewers

Comment 34

[Silaghi Andreea]

Backed out for causing gradle-dependencies failures
Backout Link
Push with failures
Failure Log

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c56443054f7a
https://hg.mozilla.org/integration/autoland/rev/d2a554711c6d
Add `isTruthy()` utility to `conventions` plugin r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/ce780535c99d
https://hg.mozilla.org/integration/autoland/rev/dc5a07b2955a
Migrate `autopublish-settings.gradle` to `SettingsPlugin` and `ProjectPlugin r=nalexander,geckoview-reviewers,android-reviewers

Comment 36

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d2a554711c6d
https://hg.mozilla.org/mozilla-central/rev/dc5a07b2955a

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1083131fcdc5
https://hg.mozilla.org/integration/autoland/rev/fd30b6a6a550
Remove redundant `Detekt` exclusions in Fenix `build.gradle` r=nalexander,android-reviewers

Comment 38

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/fd30b6a6a550

Comment 39

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Move `getManifestVersionString` into conventions plugin r?nalexander

Comment 40

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Move `updateExtensionVersion` into conventions plugin r?nalexander

Comment 41

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Move build directory transplanting into `ProjectPlugin` r?nalexander

Comment 42

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2007013 - Move `configureJniKeepDebugSymbols` into `ProjectPlugin` r?nalexander

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77db818de428
https://hg.mozilla.org/integration/autoland/rev/b9aec4fbba24
Move `getBuildId` into conventions plugin and cache result r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/58ade31699a7
https://hg.mozilla.org/integration/autoland/rev/571d97d19d03
Move `getManifestVersionString` into conventions plugin r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/0ee15e4a4d00
https://hg.mozilla.org/integration/autoland/rev/4b875efabc41
Move `updateExtensionVersion` into conventions plugin r=nalexander,geckoview-reviewers,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/1a51c3e8ee58
https://hg.mozilla.org/integration/autoland/rev/2b001cc18dc0
Move build directory transplanting into `ProjectPlugin` r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/dee0ea256ba8
https://hg.mozilla.org/integration/autoland/rev/156964dbeaec
Move `configureJniKeepDebugSymbols` into `ProjectPlugin` r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/7369b7d0e41e
https://hg.mozilla.org/integration/autoland/rev/c790e3e04f64
Consolidate A-C test/lint disabling into `SettingsPlugin` and `ProjectPlugin r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/c26a93364614
https://hg.mozilla.org/integration/autoland/rev/a97ce6bdf4e7
Consolidate Kotlin compiler message reformatter into `ProjectPlugin` r=nalexander,geckoview-reviewers,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/010477f30a11
https://hg.mozilla.org/integration/autoland/rev/a22279491827
Consolidate Kotlin `allWarningsAsErrors` configuration into `ProjectPlugin` r=nalexander,geckoview-reviewers,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/2ab17f87c2a0
https://hg.mozilla.org/integration/autoland/rev/5c97389b9e4a
Consolidate `buildToolsVersion` configuration into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/a9acccc7a504
https://hg.mozilla.org/integration/autoland/rev/121ba2b5827d
Consolidate `jvmToolchain` configuration into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ba966c009a3
https://hg.mozilla.org/integration/autoland/rev/f0d598d04ef4
Revert "Bug 2007013 - Consolidate `jvmToolchain` configuration into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers" for causing fenix debug failures at index.html

Comment 45

[Silaghi Andreea]

Backed out for causing fenix-debug failures at index.html
Backout Link
Push with failures
Failure Log
Failure line [gradle:error]: > > There were failing tests. See the report at: file:///builds/worker/workspace/obj-build/gradle/build/mobile/android/android-components/components/browser/domains/reports/tests/testDebugUnitTest/index.html

Comment 46

[Alex Hochheiden [:ahochheiden] [he/him]]

Very odd, the try run I sent just before landing passed this test: https://treeherder.mozilla.org/jobs?repo=try&author=ahochheiden%40mozilla.com&selectedTaskRun=bQbqcn2MRUaI4XeEbp2QHQ.0

Comment 47

[Alex Hochheiden [:ahochheiden] [he/him]]

Also, all those hyperlinks are broken.

Comment 48

[Alex Hochheiden [:ahochheiden] [he/him]]

Well, I changed the timing of that test removal task to happen later, hopefully that fixes it.

Try is green: https://treeherder.mozilla.org/jobs?repo=try&revision=9d2911fa4c44a7502472bb6ec035887caa207f07&selectedTaskRun=C93n2ci7QjSvYu33kWzZEA.0

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/590f05a6fb1f
https://hg.mozilla.org/integration/autoland/rev/08d6e748e25f
Move `getBuildId` into conventions plugin and cache result r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/4243db127ede
https://hg.mozilla.org/integration/autoland/rev/8a3214ae4dc1
Move `getManifestVersionString` into conventions plugin r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/e350688a4d4c
https://hg.mozilla.org/integration/autoland/rev/4ed285dbd11d
Move `updateExtensionVersion` into conventions plugin r=nalexander,geckoview-reviewers,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/e34a91ed80b2
https://hg.mozilla.org/integration/autoland/rev/50d641c8f71a
Move build directory transplanting into `ProjectPlugin` r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/073fb92a81cf
https://hg.mozilla.org/integration/autoland/rev/bb6b6561b9a4
Move `configureJniKeepDebugSymbols` into `ProjectPlugin` r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/83ae2a699d6c
https://hg.mozilla.org/integration/autoland/rev/3c5ccfac4fe1
Consolidate A-C test/lint disabling into `SettingsPlugin` and `ProjectPlugin r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/fb4ab226a313
https://hg.mozilla.org/integration/autoland/rev/68ee00412586
Consolidate Kotlin compiler message reformatter into `ProjectPlugin` r=nalexander,geckoview-reviewers,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/990549713763
https://hg.mozilla.org/integration/autoland/rev/ff566a71e88c
Consolidate Kotlin `allWarningsAsErrors` configuration into `ProjectPlugin` r=nalexander,geckoview-reviewers,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/6c0a0adb82de
https://hg.mozilla.org/integration/autoland/rev/d9e599707839
Consolidate `buildToolsVersion` configuration into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/f6d245f331c9
https://hg.mozilla.org/integration/autoland/rev/d138d26b04d6
Consolidate `jvmToolchain` configuration into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers

Comment 50

[amarc]

https://hg.mozilla.org/mozilla-central/rev/08d6e748e25f
https://hg.mozilla.org/mozilla-central/rev/8a3214ae4dc1
https://hg.mozilla.org/mozilla-central/rev/4ed285dbd11d
https://hg.mozilla.org/mozilla-central/rev/50d641c8f71a
https://hg.mozilla.org/mozilla-central/rev/bb6b6561b9a4
https://hg.mozilla.org/mozilla-central/rev/3c5ccfac4fe1
https://hg.mozilla.org/mozilla-central/rev/68ee00412586
https://hg.mozilla.org/mozilla-central/rev/ff566a71e88c
https://hg.mozilla.org/mozilla-central/rev/d9e599707839
https://hg.mozilla.org/mozilla-central/rev/d138d26b04d6

Comment 51

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cc325d364a91
https://hg.mozilla.org/integration/autoland/rev/100e0d3d07c4
Consolidate Glean version resolution into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/f8e354dce5f8
https://hg.mozilla.org/integration/autoland/rev/da7bcd9e9af2
Consolidate ktlint configuration into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/bdd0eadde0a4
https://hg.mozilla.org/integration/autoland/rev/cdc217f84ee2
Consolidate test output formatting into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/bf83a7bbe6bc
https://hg.mozilla.org/integration/autoland/rev/f17dab8aac26
Consolidate `printVariants` task into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/d7056fdecfcd
https://hg.mozilla.org/integration/autoland/rev/22b14a7e629c
Consolidate `packaging.resources.excludes` into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/00fed0b4eb52
https://hg.mozilla.org/integration/autoland/rev/361d2c093e40
Remove unused GeckoView dependency substitution r=nalexander,android-reviewers,jonalmeida

Comment 52

[rperta]

Backed out for causing gradle failures
Backout link
Push with failures
Failure log(s)

Comment 53

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ece9c68ec7dd
https://hg.mozilla.org/integration/autoland/rev/18df90739012
Consolidate Glean version resolution into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/0e15a8f1a7e1
https://hg.mozilla.org/integration/autoland/rev/195020b03c05
Consolidate ktlint configuration into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/19ed7287d9b9
https://hg.mozilla.org/integration/autoland/rev/ee4c8535e3e1
Consolidate test output formatting into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/d1984e4d0e78
https://hg.mozilla.org/integration/autoland/rev/b86a9a64e8c3
Consolidate `printVariants` task into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/9868ac230a8f
https://hg.mozilla.org/integration/autoland/rev/851aba5b8f6d
Consolidate `packaging.resources.excludes` into `ProjectPlugin` r=nalexander,android-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/d9c4ae3994e4
https://hg.mozilla.org/integration/autoland/rev/4c829b5e6b0f
Remove unused GeckoView dependency substitution r=nalexander,android-reviewers,jonalmeida

Comment 54

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/18df90739012
https://hg.mozilla.org/mozilla-central/rev/195020b03c05
https://hg.mozilla.org/mozilla-central/rev/ee4c8535e3e1
https://hg.mozilla.org/mozilla-central/rev/b86a9a64e8c3
https://hg.mozilla.org/mozilla-central/rev/851aba5b8f6d
https://hg.mozilla.org/mozilla-central/rev/4c829b5e6b0f

Comment 55

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/18df90739012
https://hg.mozilla.org/mozilla-central/rev/195020b03c05
https://hg.mozilla.org/mozilla-central/rev/ee4c8535e3e1
https://hg.mozilla.org/mozilla-central/rev/b86a9a64e8c3
https://hg.mozilla.org/mozilla-central/rev/851aba5b8f6d
https://hg.mozilla.org/mozilla-central/rev/4c829b5e6b0f