1984011 - Use more constant initalisation in mozjemalloc

Status: RESOLVED FIXED

(Core :: Memory Allocator, task)

Description

[Paul Bone [:pbone]]

While I was working on something else I found that it was useful to give more mozjemalloc classes constexpr constructors so that they didn't need runtime initialisation.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1984011 - pt 1. Make DoublyLinkedList's constructor constexpr r=glandium

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1984011 - pt 2. Make RedBlackTree's constructor constexpr r=glandium

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1984011 - pt 3. Make StaticMutex's constructor constexpr r=glandium

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1984011 - pt 4. Mutex now has a constexpr constructor on all platforms r=glandium

On windows Mutex still needs its Init method called before it can be
used - it's constructor won't fully initalise it.

Comment 5

[Paul Bone [:pbone]]

Attachment: Bug 1984011 - pt 5. Give AddressRadixTree a constexpr constructor r=glandium

Comment 6

[Paul Bone [:pbone]]

Attachment: Bug 1984011 - pt 6. Give ArenaCollection a constexpr constructor r=glandium

Comment 7

[Paul Bone [:pbone]]

Attachment: Bug 1984011 - pt 7. Add assertions to Mutex's initialisation r=glandium

Comment 8

[Paul Bone [:pbone]]

Attachment: Bug 1984011 - pt 8. Simplify the arena_t constructor r=glandium

Use more:

• initialisers in the class definition,
• initialiser lists in the constructor and
• default constructors for class members
  so that code can be removed from the body of the constructor.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/730dfc3c12b6
https://hg.mozilla.org/integration/autoland/rev/b47dcaccd94e
pt 1. Make DoublyLinkedList's constructor constexpr r=glandium
https://github.com/mozilla-firefox/firefox/commit/08a04985b811
https://hg.mozilla.org/integration/autoland/rev/fecd5523c09e
pt 2. Make RedBlackTree's constructor constexpr r=glandium
https://github.com/mozilla-firefox/firefox/commit/201ebb959d5c
https://hg.mozilla.org/integration/autoland/rev/09e881d4a54f
pt 3. Make StaticMutex's constructor constexpr r=glandium
https://github.com/mozilla-firefox/firefox/commit/bc281b7f56d8
https://hg.mozilla.org/integration/autoland/rev/5b9b9808143d
pt 4. Mutex now has a constexpr constructor on all platforms r=glandium
https://github.com/mozilla-firefox/firefox/commit/acf68cbd78a4
https://hg.mozilla.org/integration/autoland/rev/9c04c98d079f
pt 5. Give AddressRadixTree a constexpr constructor r=glandium
https://github.com/mozilla-firefox/firefox/commit/649b1ba94934
https://hg.mozilla.org/integration/autoland/rev/c25285547a5b
pt 6. Give ArenaCollection a constexpr constructor r=glandium
https://github.com/mozilla-firefox/firefox/commit/6f863d55e907
https://hg.mozilla.org/integration/autoland/rev/66d3356412f1
pt 7. Add assertions to Mutex's initialisation r=glandium
https://github.com/mozilla-firefox/firefox/commit/2eb99af37475
https://hg.mozilla.org/integration/autoland/rev/af20cca0645a
pt 8. Simplify the arena_t constructor r=glandium

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b47dcaccd94e
https://hg.mozilla.org/mozilla-central/rev/fecd5523c09e
https://hg.mozilla.org/mozilla-central/rev/09e881d4a54f
https://hg.mozilla.org/mozilla-central/rev/5b9b9808143d
https://hg.mozilla.org/mozilla-central/rev/9c04c98d079f
https://hg.mozilla.org/mozilla-central/rev/c25285547a5b
https://hg.mozilla.org/mozilla-central/rev/66d3356412f1
https://hg.mozilla.org/mozilla-central/rev/af20cca0645a