1991374 - Does SRWLock still create a regression in mozjemalloc?

Status: RESOLVED WONTFIX

(Core :: Memory Allocator, task)

Description

[Paul Bone [:pbone]]

Some time ago we tried to use SRWLock in mozjemalloc Bug 1417234 because it allows static initialisation which makes our lives better. But it created a performance regression. Is that still true?

Comment 1

[Paul Bone [:pbone]]

There might be a slight performance regression switching to SRWLock:

https://perf.compare/compare-lando-results?baseLando=155467&newLando=155468&baseRepo=try&newRepo=try&framework=13&search=speedometer

https://perf.compare/compare-lando-results?baseLando=155467&newLando=155468&baseRepo=try&newRepo=try&framework=13&filter_confidence=medium%2Chigh

Comment 2

[Paul Bone [:pbone]]

Closing as WONTFIX because SRWLock is slightly slower.

Comment 3

[Paul Bone [:pbone]]

Attachment: WIP: Bug 1991374 - Use SRWLock on Windows

SRWLock uses static initialisation but it's a little slower.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)