1984234 - about:preferences UI to toggle opening external links next to active tab

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P2)

Description

[Stephen Thompson [:sthompson]]

The pref in bug 1984233 should control whether external links will open under current rules (generally speaking, at the end of the tab strip) or next to the active tab. Users should be able to control this manually in about:preferences (the application settings UI).

Comment 1

[Ania]

String for the about:preferences

Open links from apps next to your active tab

Placement
The new setting should be placed in General > above this current setting:

Open links in tabs instead of new windows

Comment 2

[Stephen Thompson [:sthompson]]

Attachment: Bug 1984234 - settings UI to toggle opening external links next to the active tab r=dwalker,jswinarton

Add a new checkbox to the General > Tabs section of about:preferences to allow the user to open external links next to the active tab.

The current behavior defaults to looking up browser.link.open_newwindow.override.external, and if that's the default of -1, it falls back to browser.link.open_newwindow which defaults to 3 (open a new tab at the end of the tab strip).

We want the settings UI to be simple, so it's a checkbox to set the value of browser.link.open_newwindow.override.external to 7, which indicates opening external links next to the active tab. However, we don't want unchecking the box to force browser.link.open_newwindow.override.external back to the default -1 since a user might have set that to one of the other 6 valid values, e.g. opening as a new background tab. This patch includes some extra logic to make the checkbox toggle between 7 and whatever value the pref had when the user loaded about:preferences.

If the user toggles the checkbox on and then refreshes about:preferences, restarts the browser, etc., then their previous value will not be retained and unchecking the checkbox will revert the setting to -1.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/84d778b41021
https://hg.mozilla.org/integration/autoland/rev/47fef0c98d59
settings UI to toggle opening external links next to the active tab r=fluent-reviewers,mstriemer,bolsson

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/47fef0c98d59