Closed Bug 1984884 Opened 10 months ago Closed 10 months ago

After update 142.0, problem with printing the selection menu in html "select name" only an empty frame is displayed.

Categories

(Core :: Printing: Output, defect)

Firefox 142
defect

Tracking

()

VERIFIED FIXED
144 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox-esr140 --- unaffected
firefox142 + verified
firefox143 + verified
firefox144 + verified

People

(Reporter: nfs, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Steps to reproduce:

All browsers with new update. After update 142.0, the print request cannot be printed from the page where the code option is selected.

<select name="platba"><option value="jb">Hotovost</option><option selected="selected" value="hs">Platební kartou</option></select>
<a name="option"></a>

Actual results:

only an empty frame is displayed without the selected item

Expected results:

print the selected value

The Bugbug bot thinks this bug should belong to the 'Core::Printing: Output' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Printing: Output
Product: Firefox → Core

Mozregression says this is a result of bug 1873301.

Marking S2 as it's a recent regression, and causes some content to unexpectedly go missing in print/pdf output.

Severity: -- → S2
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(emilio)
Keywords: regression
Regressed by: 1873301

Set release status flags based on info from the regressing bug 1873301

So that we have the right index when creating the anonymous content,
without needing to reflow first.

This is the low-risk fix for uplift. More complete fix to come.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

This is what papered over this in non-printing scenarios.

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54497 for changes under testing/web-platform/tests

Comment on attachment 9509144 [details]
Bug 1984884 - Set displayed index in nsComboboxControlFrame::Init. r=#layout-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: missing content in print
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial one-liner
  • String changes made/needed: none
  • Is Android affected?: Yes
Flags: needinfo?(emilio)
Attachment #9509144 - Flags: approval-mozilla-release?
Attachment #9509144 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Pushed by ealvarez@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b4e82f5c1523 https://hg.mozilla.org/integration/autoland/rev/498fd968d39d Stop re-setting the selected text in nsComboboxControlFrame::Reflow. r=layout-reviewers,dshin
Duplicate of this bug: 1984926
Duplicate of this bug: 1985089
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
Upstream PR merged by moz-wptsync-bot

Comment on attachment 9509144 [details]
Bug 1984884 - Set displayed index in nsComboboxControlFrame::Init. r=#layout-reviewers

Approved for 143.0b5

Attachment #9509144 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Duplicate of this bug: 1977839

Comment on attachment 9509144 [details]
Bug 1984884 - Set displayed index in nsComboboxControlFrame::Init. r=#layout-reviewers

Approved for 142.0.1

Attachment #9509144 - Flags: approval-mozilla-release? → approval-mozilla-release+
Duplicate of this bug: 1985342
Blocks: 1977839
No longer duplicate of this bug: 1977839
QA Whiteboard: [qa-ver-needed-c144/b143]

Reproduced the initial issue using an old Nightly build from 2 days ago. Verified that using latest Nightly 144.0a1, Firefox 142.0.1 and latest Beta 143 build from treeherder across platforms (Windows 10, macOS 13 and Ubuntu 22.04) this is no longer an issue for both print preview or printing to pdf.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-needed-c144/b143] → [qa-ver-done-c144/b143]
Flags: qe-verify+
Duplicate of this bug: 1985565
Regressions: 1986616

(In reply to Cosmin Sabou [:CosminS] from comment #12)

https://hg.mozilla.org/mozilla-central/rev/fa5150f4a96a
https://hg.mozilla.org/mozilla-central/rev/498fd968d39d

Hi Emilio,

Would you agree that revision fa5150f4a96a5160bb0813d921d5ef4c50067f53 caused the improvements mentioned below ?

That revision is in a busted range and we cannot run the android booking jobs on that revision, but based on the initial regression ((bug 1977839)[https://bugzilla.mozilla.org/show_bug.cgi?id=1977839]), this seemed to be the most likely culprit.

Perfherder has detected a browsertime performance change from push fa5150f4a96a5160bb0813d921d5ef4c50067f53.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
20% booking largestContentfulPaint android-hw-a55-14-0-aarch64-shippable warm webrender 206.97 -> 166.28
19% booking FirstVisualChange android-hw-a55-14-0-aarch64-shippable warm webrender 203.93 -> 164.35
15% booking fcp android-hw-a55-14-0-aarch64-shippable warm webrender 176.89 -> 150.49
9% booking ContentfulSpeedIndex android-hw-a55-14-0-aarch64-shippable warm webrender 291.52 -> 264.78
5% booking SpeedIndex android-hw-a55-14-0-aarch64-shippable warm webrender 530.04 -> 501.57
3% booking PerceptualSpeedIndex android-hw-a55-14-0-aarch64-shippable warm webrender 690.28 -> 669.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 46515

The following documentation link provides more information about this command.

Flags: needinfo?(emilio)

Yes that's why I marked https://bugzilla.mozilla.org/show_bug.cgi?id=1977839 as a dupe of this one.

Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: