1986289 - enter key in message filter edit closes the dialog - allows accidental catch-all rules

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Christian Gärtner]

Steps to reproduce:

While adding rules to a filter I added a new "From, ends with" rule, typed the end of the email address in the provided field and pressed the Enter key. This adds another rule of the same type with a blank field(!) then immediately also closes the filter editor.
This filter now matches every single email, because technically, any sender email ends with an empty string. Obviously, this also applies to "starts with" rules.

Actual results:

Running this faulty filter cleared out my entire spam folder, permanently removing the emails. Not a big deal obviously, but clearly not what I intended.

Expected results:

Thunderbird should've detected a "starts with" / "ends with" rule with a blank field, concluding there's a 99.99% chance this is not what the user intended, and warned about it.

Comment 1

[Wayne Mery (:wsmwk)]

The real problem here is closing the dialog with the enter key. Aceman fixed this problem 13 years ago in Bug 49474 - Filter editor UI: Enter key after entering criteria closes dialog.

So apparently this has regressed. No idea when.

Comment 2

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=cd367a28aeb935df9b62bfb563980fdfc1f3905a&tochange=bddc7eeb6720ddcaf31bdafc85d47166d0414a5a
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=a632dfa60af6edd4f7dd03d404d898b6222b56c3&tochange=adc32d869e58d0c052094f718bc9e4cff8390be4

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1986289 - Do not close Filter Rules dialog by Return key after entering search value. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/037434bf26d8
Do not close Filter Rules dialog by Return key after entering search value. r=mkmelin