Closed
Bug 198736
Opened 22 years ago
Closed 22 years ago
Make nsTraceRefcnt bloat test less prominent.
Categories
(Webtools Graveyard :: Tinderbox, defect)
Webtools Graveyard
Tinderbox
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Whiteboard: [patch])
Attachments
(1 file)
2.73 KB,
patch
|
bryner
:
review+
|
Details | Diff | Splinter Review |
alecf doesn't like the nsTraceRefcnt-based bloat test info on tinderbox, and I
generally agree. However, the good ones are sometimes noisy, and the
nsTraceRefcnt leak test (as opposed to the bloat test) can often add useful
information.
So what I propose is that we change what the TinderboxPrint statements in
question do:
* print RLk: instead of Lk:
* don't print Bl: at all.
I'll attach a patch that I think does this, although I haven't tested it.
Does this make sense?
Assignee | ||
Comment 1•22 years ago
|
||
It looks, at first glance, like the mail leak/bloat tests use this function.
They should probably be converted to using BloatTest2 before we do this...
Assignee | ||
Updated•22 years ago
|
Whiteboard: [patch]
Assignee | ||
Updated•22 years ago
|
Attachment #118139 -
Flags: review?(bryner)
Updated•22 years ago
|
Summary: Make nsTraceRefcnt bloat test lest prominent. → Make nsTraceRefcnt bloat test less prominent.
Updated•22 years ago
|
Attachment #118139 -
Flags: review?(bryner) → review+
Assignee | ||
Comment 2•22 years ago
|
||
Fix checked in to trunk, 2004-01-21 12:56 -0800.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•