28804 - bloat totals are inaccurate

Status: RESOLVED DUPLICATE of bug 198736

(Webtools Graveyard :: Tinderbox, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is really a cross-product bug (Tinderbox and Browser), but since most of
the work involved is probably testing on the tinderbox end, I'm filing it
there.  This is a spin-off of bug 28413.

Right now, the tinderbox bloat totals are inaccurate.  nsTraceRefcnt.cpp divides
the total bloat by the number of objects leaks, and then rounds it to the
nearest integer (it's around 40).  Then tinderbox multiplies these numbers
again.  This means that the bloat stats are accurate to only 1 part in 40.  It
also means, perhaps more importantly, that they are correctly sensitive to
changes in object numbers, but extremely insensitive to changes in object size
(unless they happen to be at one of the class-size threshholds, in which case
they are extremely oversensitive).

I think the changes necessary to correct this are two lines of code:  one in the
browser and one in tinderbox.  (In other words, we could print the total bloat
instead of the average class size on the TOTAL line, which I think makes more
sense.)  I'll try to attach the patches later.  (There may be a few other minor
changes needed.)  However, they may need to be tested before they can be used.

Comment 1

[Dawn Endico]

slamm no longer owns tinderbox and is no longer at netscape. Reassigning
to mcafee till a more permenant owner is found so these bugs won't be
ownerless.

Comment 2

[Dawn Endico]

Unsetting target milestone so we can delete the old (inappropriate)
Mozilla target milestones from Webtools.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No longer relevant now that we no longer use the test for much.

*** This bug has been marked as a duplicate of 198736 ***