1987437 - Artifact build fails with `ValueError: Must provide path to exactly one of hg and git`

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

This morning, after a fresh pull, I noticed that I can't do artifact builds on my macOS machine (Sonoma 14.4.1).

Here's the error message I get:

mikeconley@MacBook-Pro firefox % ./mach build
Using JujutsuRepository because a ".jj/" directory was detected!

Warning: jj support is currently experimental, and may be disabled by setting the
environment variable MOZ_AVOID_JJ_VCS=1. (This warning may be suppressed by
setting MOZ_AVOID_JJ_VCS=0.)
 0:00.48 W Clobber not needed.
 0:00.70 W Adding make options from /Users/mikeconley/.mozconfigs/artifact
    AUTOCLOBBER=1
    BROWSER_NEWTAB_AS_ADDON=1
    MOZ_OBJDIR=/Users/mikeconley/Projects/firefox/obj-artifact
    OBJDIR=/Users/mikeconley/Projects/firefox/obj-artifact
    FOUND_MOZCONFIG=/Users/mikeconley/.mozconfigs/artifact
    export FOUND_MOZCONFIG
  Parallelism determined by memory: using 12 jobs for 12 cores based on 36.0 GiB RAM and estimated job size of 1.0 GiB
 0:00.70 /usr/bin/make -f client.mk -j12 -s
 0:00.97 Using JujutsuRepository because a ".jj/" directory was detected!
 0:00.97 Warning: jj support is currently experimental, and may be disabled by setting the
 0:00.97 environment variable MOZ_AVOID_JJ_VCS=1. (This warning may be suppressed by
 0:00.97 setting MOZ_AVOID_JJ_VCS=0.)
 0:01.95 Error running mach:
 0:01.95     mach --log-no-times artifact install
 0:01.95 The error occurred in code that was called by the mach command. This is either
 0:01.95 a bug in the called code itself or in the way that mach is calling it.
 0:01.95 You can invoke ``./mach busted`` to check if this issue is already on file. If it
 0:01.95 isn't, please use ``./mach busted file artifact`` to report it. If ``./mach busted`` is
 0:01.95 misbehaving, you can also inspect the dependencies of bug 1543241.
 0:01.95 If filing a bug, please include the full output of mach, including this error
 0:01.95 message.
 0:01.95 The details of the failure are as follows:
 0:01.95 ValueError: Must provide path to exactly one of hg and git
 0:01.95   File "/Users/mikeconley/Projects/firefox/python/mozbuild/mozbuild/artifact_commands.py", line 191, in artifact_install
 0:01.95     artifacts = _make_artifacts(
 0:01.95                 ^^^^^^^^^^^^^^^^
 0:01.95   File "/Users/mikeconley/Projects/firefox/python/mozbuild/mozbuild/artifact_commands.py", line 118, in _make_artifacts
 0:01.95     artifacts = Artifacts(
 0:01.95                 ^^^^^^^^^^
 0:01.95   File "/Users/mikeconley/Projects/firefox/python/mozbuild/mozbuild/artifacts.py", line 1203, in __init__
 0:01.95     raise ValueError("Must provide path to exactly one of hg and git")
 0:01.95 Sentry event ID: e061e9c9ffbe41b8adcdfc75da5bdb42
 0:02.05 Sentry is attempting to send 2 pending events
 0:02.05 Waiting up to 2 seconds
 0:02.05 Press Ctrl-C to quit
 0:02.15 make[3]: *** [recurse_artifact] Error 1
 0:02.15 make[2]: *** [artifact] Error 2
 0:02.15 make[1]: *** [default] Error 2
 0:02.15 make: *** [build] Error 2
 0:02.25 W 0 compiler warnings present.

A clobber build, clobbering artifacts, and running bootstrap do not seem to help here. I also thought this might have something to do with my usage of jujutsu, but I'm getting the same issue with a classic git clone as well.

Comment 1

[Alex Hochheiden [:ahochheiden]]

I'll investigate. This might be tied to :sfink's patch that landed recently.

Comment 2

[Alex Hochheiden [:ahochheiden]]

Very likely to be D262706 from bug 1985174.

Comment 3

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1987437 - Fix artifact builds when using `jj` VCS r?#build,sfink

Comment 4

[Alex Hochheiden [:ahochheiden]]

I can't repro (tried deleting all my artifacts, too), but I think that patch should fix it.

:mconley can you verify it for me? Thanks!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Testing...

Comment 6

[Mike Conley (:mconley) (:⚙️)]

I can confirm this fixes artifact builds for me. Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b52d3198fbc3
https://hg.mozilla.org/integration/autoland/rev/72b425381f79
Fix artifact builds when using `jj` VCS r=sfink,firefox-build-system-reviewers,nalexander

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/72b425381f79