198802 - Expose raw output to user via link

Status: RESOLVED FIXED

(Webtools Graveyard :: MXR, enhancement)

Description

[Alex Vincent [:WeirdAl]]

The raw output view of a file is occasionally useful to developers (those
without CVS and who need a source file without HTML markup).  A one-line
insertion to the template-source-head file would provide a link to the raw
source without much trouble.

     <TR>
      <TD NOWRAP BGCOLOR="#FAFAFA">
       <A HREF="http://bonsai.mozilla.org/cvslog.cgi?file=mozilla$pathname">CVS
Log</A><BR>
       <A
HREF="http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla$pathname">CVS
Blame</A><BR>
+      <A HREF="?raw=1">Raw output</A><BR>
       <BR>
      </TD>
     </TR>

Comment 1

[Dave Miller [:justdave]]

I recommend WONTFIX.

When we eventually get around to having it obfuscate email addresses in the
source in the HTMLized version, having an actual link to the raw version will
lead the spammers right back to the unobfuscated email addresses, thereby
defeating the purpose of the obfuscating.

I'd have no argument against providing instructions to alter your URL on the
page though.  I think right now you have to "know about it" to find it.

Comment 2

[Alex Vincent [:WeirdAl]]

Well, if you'd be willing to accept giving instructions on how to find it, how
about tacking the following code onto the end of the file, after line 59:

<P>To get the raw source code without HTML markup, add ?raw=1 to the URL in your
location bar.</P>

Comment 3

[(not currently active) Ted Mielczarek]

FYI, I had two people ask for this today.

Maybe you could make it a javascript link, if you're worried about spambots
finding email addresses?  I'd at least like to have the instructions for how to
do it in there.

Comment 4

[timeless]

i'm not going to do the js version. a bookmarklet hosted on jesse's site would
be fine. but nothing near the page. i have access to code which would find the
email addresses if it wanted to and we exposed such a link.

at some point i'm going to post a patch/bug somewhere to improve the lxr front
page. perhaps we wouldn't be averse to including the helpful hint there.

Comment 5

[Dave Miller [:justdave]]

reassigning endico's bugs to default owner

Comment 6

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 7

[Frédéric Buclin]

(In reply to comment #1)
> I recommend WONTFIX.
> 
> When we eventually get around to having it obfuscate email addresses

I disagree. For two reasons: first because you said that 3 years ago and email addresses are still not obfuscated, and secondly because a spammer who really want to use LXR to get email addresses wouldn't need too much time to automatically add raw=1 in the URL to get them. So this reason is weak IMO.

Comment 8

[Dave Miller [:justdave]]

*** Bug 336089 has been marked as a duplicate of this bug. ***

Comment 9

[Dave Miller [:justdave]]

(In reply to comment #7)
> > When we eventually get around to having it obfuscate email addresses
> 
> you said that 3 years ago and email addresses are still not obfuscated

Irrelevant.  There's been nobody working on it.  Just because something hasn't been implemented yet is no reason to permanently sabotage ever being able to implement it.

> and secondly because a spammer who really want to use LXR to get email
> addresses wouldn't need too much time to automatically add raw=1 in the URL
> to get them. So this reason is weak IMO.

If they really want to use LXR to get addresses, they're going to get them anyway no matter what we do.  The idea is to stop the spammers who just randomly spider the web looking for addresses.

Comment 10

[Dave Miller [:justdave]]

That said, I should say that my personal opinion these days is that spam is going to happen no matter what you do, so if you really care, just get better email filters on your mail client.

I'm ambivalent on this feature for that reason, I'm mainly fighting for it only  because I've heard a lot of noise being made by other folks about it.

Comment 11

[Frédéric Buclin]

Attachment: patch based on comment 0

I copied what was suggested in comment 0. Untested as I have no LXR installation.

Comment 12

[Mike Taylor [:bear]]

updating my LXR install to test this - the time it takes for me to do that will give anyone who truly thinks this is bad fix to speak up (i.e. a couple days)

Comment 13

[Mike Taylor [:bear]]

Comment on attachment 220419 [details] [diff] [review]
patch based on comment 0

I had some idle time while waiting for a tinderbox cycle :)

Tested fine using the latest LXR source on my local setup

Comment 14

[Mike Taylor [:bear]]

patch applied as revision 1.12

Comment 15

[timeless]

*** Bug 164720 has been marked as a duplicate of this bug. ***