1988105 - Incorrect bottom padding to homepage elements

Status: RESOLVED FIXED

(Firefox for Android :: Homepage, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: HomepageItemsBottomClipped.mp4

Seems like we're computing the wrong value for the bottom toolbar for a while now
bug 1983299 tried to improve it so today we're using

• microsurvey + navbar height
• constant for the app name header
• wanted spacing between toolbar and home content

What's missing from this is the height of the tabstrip and that of the toolbar.
The app name logo at the top also doesn't appear if middle search bar is enabled so this has to be accounted for dynamically instead of being hardcoded.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Given that this depends also on how we infer the top toolbar and bottom toolbar's height which can be improved
I'll take a stab at fixing these as a whole.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1988105 - part 1 - Improve APIs for inferring top toolbar and bottom toolbar heights r=#android-reviewers

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1988105 - part 2 - Simpler way of padding the home content r=#android-reviewers

All widgets on the homescreen are placed absolutely on the same canvas.
This means that the home content would be clipped by the top/bottom
toolbar or other such widgets and to prevent that it needs to have the
appropriate vertical margins set.
We can do this in just one place for all versions of the home content
for simpler yet more powerful functionality by also supporting the
different screen orientations for which the content needs different
margins as other widgets may be shown for each orientation.
One scenario which is not supported it that of the microsurvey
being shown/closed, this is to be fixed in bug 1988142.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1988105 - part 3 - Remove separate home header padding r=#android-reviewers

This would always push the home content down, even when it is
not being shown - when search bar in the middle ios observed.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1988105 - part 4 - Use a 47dp bottom padding also when not using search in the middle r=#android-reviewers

Both versions of the home content will now have the same bottom padding.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1988105 - part 5 - New way of detecting in UI tests when the toolbar is at the bottom/top of the screen r=#android-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45962bcda47d
https://hg.mozilla.org/integration/autoland/rev/17e747bd8682
part 1 - Improve APIs for inferring top toolbar and bottom toolbar heights r=android-reviewers,skhan,devota
https://github.com/mozilla-firefox/firefox/commit/a306fbbb1fde
https://hg.mozilla.org/integration/autoland/rev/83c6eaad06d9
part 2 - Simpler way of padding the home content r=android-reviewers,devota
https://github.com/mozilla-firefox/firefox/commit/11fa00becbff
https://hg.mozilla.org/integration/autoland/rev/3e80d249a042
part 3 - Remove separate home header padding r=android-reviewers,devota
https://github.com/mozilla-firefox/firefox/commit/c7ba64568fd0
https://hg.mozilla.org/integration/autoland/rev/1d785830feac
part 4 - Use a 47dp bottom padding also when not using search in the middle r=android-reviewers,Roger,devota
https://github.com/mozilla-firefox/firefox/commit/6e1bbca89063
https://hg.mozilla.org/integration/autoland/rev/fa6618089d07
part 5 - New way of detecting in UI tests when the toolbar is at the bottom/top of the screen r=ajoltan

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/17e747bd8682
https://hg.mozilla.org/mozilla-central/rev/83c6eaad06d9
https://hg.mozilla.org/mozilla-central/rev/3e80d249a042
https://hg.mozilla.org/mozilla-central/rev/1d785830feac
https://hg.mozilla.org/mozilla-central/rev/fa6618089d07