1998100 - Empty strip remains and stories section cut when scrolling on homescreen with the toolbar set to top with composable toolbar disabled

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Lorand Janos]

Attachment: Edited_20251104_112710.mp4

Steps to reproduce

1. Make sure Composable toolbar is disabled from Secret Settings.
2. Make sure to have the toolbar set on top in Settings>Customize.
3. Go to homescreen and scroll down.
4. Observe the top part of the screen.

Expected behavior

The whole screen is scrolled.

Actual behavior

• There's an empty strip above the logo and the PB icon that remains there when scrolling.
• Stories section is either cut or not reachable on some devices.

Device information

• Firefox versions: Nightly 146.0a1, Beta 145.0b9, RC 145.0
• Android device model: OnePlus 13R
• Android OS version: 15

Any additional information?

As the composable toolbar is not enabled by default on the latest Beta (145.0b9) and latest RC 145.0 builds, the issue is reproducible without any additional settings, on Nightly the feature needs to be turned off in order to reproduce the issue.

• Last good build: Nightly 145.0a1 from 2025-09-17-16-16-33.
• First bad build: Nightly 145.0a1 from 2025-09-18-09-15-32.

Comment 1

[Lorand Janos]

Attachment: recording_20251111_101726.mp4

Stories section is not reachable on Lenovo TB X606X (Android 10)

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1998100 - part 1 - Don't add a top padding on homepage if using the View based toolbar r=#android-reviewers

The View based toolbar is part of the layout while the composable toolbar is
added as an overlay so only n this case the padding is needed.

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1988105

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1998100 - part 2 - Ensure the right bottom padding depending on the top View based toolbar r=#android-reviewers

This is an old bug stemming from the act that home Views are not shown in a
vertical layout group but rather independent from each other so they need
custom padding set to ensure a consistent UI.
(Fix/issue can be observed more easily if the tabstrip is also enabled)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dd3c500a9dd8
https://hg.mozilla.org/integration/autoland/rev/9e05261f9cde
part 1 - Don't add a top padding on homepage if using the View based toolbar r=android-reviewers,Roger
https://github.com/mozilla-firefox/firefox/commit/6b0ded1484ea
https://hg.mozilla.org/integration/autoland/rev/90d390c049c7
part 2 - Ensure the right bottom padding depending on the top View based toolbar r=android-reviewers,Roger

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/9e05261f9cde
https://hg.mozilla.org/mozilla-central/rev/90d390c049c7

Comment 9

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Adina Petridean QA [:apetridean]]

This issue is still reproducible on the latest Nightly 147.0a1 (2025-11-13) using a Moto G72 (Android 13) and a Realme 14 Pro+ 5G (Android 15). On both devices, both issues are reproducible — the empty strip and the cut Stories section.
On a Samsung S25 Ultra (Android 15) and a Google Pixel 10 (Android 16), the empty strip does not appear, but the Stories section is still cut.

Comment 11

[Adina Petridean QA [:apetridean]]

Attachment: Record_2025-11-17-14-53-32_984e1414ae90666a90f12ff17ec14a7f.mp4

Verified as fixed on the latest Nighlty 147.0a1 with Realme 14 Pro + 5G - Android 15, Moto G72 (Android 13) , and Google Pixel 10 (Android 16).

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1998100 - part 1 - Don't add a top padding on homepage if using the View based toolbar

The layout is updated to account for the top View based toolbar inside
HomeToolbarView already.

Original Revision: https://phabricator.services.mozilla.com/D272235

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Incorrect margins for the content of the home screen resulting in either empty space at the top either content being clipped at the bottom.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=1998100#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Small targeted change verified by QA in Nightly.
• String changes made/needed: --
• Is Android affected?: yes

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1998100 - part 2 - Ensure the right bottom padding depending on the top View based toolbar

This is an old bug stemming from the act that home Views are not shown in a
vertical layout group but rather independent from each other so they need
custom padding set to ensure a consistent UI.
(Fix/issue can be observed more easily if the tabstrip is also enabled)

Original Revision: https://phabricator.services.mozilla.com/D272243

Comment 15

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1998100 - part 1 - Don't add a top padding on homepage if using the View based toolbar

The layout is updated to account for the top View based toolbar inside
HomeToolbarView already.

Original Revision: https://phabricator.services.mozilla.com/D272235

Comment 16

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: Incorrect margins for the content of the home screen resulting in either empty space at the top either content being clipped at the bottom.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=1998100#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Small targeted change verified by QA in Nightly.
• String changes made/needed: --
• Is Android affected?: yes

Comment 17

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1998100 - part 2 - Ensure the right bottom padding depending on the top View based toolbar

This is an old bug stemming from the act that home Views are not shown in a
vertical layout group but rather independent from each other so they need
custom padding set to ensure a consistent UI.
(Fix/issue can be observed more easily if the tabstrip is also enabled)

Original Revision: https://phabricator.services.mozilla.com/D272243

Comment 18

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/50d221ef4414
https://hg.mozilla.org/releases/mozilla-release/rev/87a7effaa57b
https://github.com/mozilla-firefox/firefox/commit/6af1b1244462
https://hg.mozilla.org/releases/mozilla-release/rev/29becb554e2b

Comment 19

[Adina Petridean QA [:apetridean]]

Verified as fixed on the RC 145.0.1 with Samsung S24 Ultra (Android 15).

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e8b19e12ae4d
https://hg.mozilla.org/releases/mozilla-beta/rev/4be0b83fe421
https://github.com/mozilla-firefox/firefox/commit/1c738d71cdb5
https://hg.mozilla.org/releases/mozilla-beta/rev/a30b5a4c630d

Comment 22

[Adina Petridean QA [:apetridean]]

Verified as fixed on Fenix 146.0b5 using a Google Pixel 10 (Android 16) and a Moto G72 (Android 13). However, we opened a new issue exclusively affecting tablets in strip mode.