1988596 - Enable layout.css.text-autospace.enabled on Nightly

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Per suggestion in bug 1987997 comment 3, we'd want to enable text-autospace on Nightly for a few weeks to gather feedback and to have CI report any performance regressions in the early 145 cycle.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1988596 - Enable layout.css.text-autospace.enabled on Nightly.

Comment 2

[Sebastian Zartner [:sebo]]

A note for this should be added to https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features and https://developer.mozilla.org/de/docs/Mozilla/Firefox/Releases/145 (once it exists). And it is also worth adding this to the Nightly release notes. Ting-Yu Lin, can you request to add it to the Firefox release notes?

Sebastian

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Sounds like a good idea adding a release note.

Here is the release note in bug 1981086 comment 1. I like the wording, so I copy & paste it here to keep it consistent when we are ready to ship the feature (hopefully also in 145 cycle). (Note: I remove "around punctuation" in the suggested wording, because we are not planning to implement bug 1986500, and no other browser supports it.

Release Note Request (optional, but appreciated)
[Why is this notable]: Gives authors control over the spacing between adjacent characters.
[Affects Firefox for Android]: yes
[Suggested wording]: Implemented support for the text-autospace property, which provides authors control over the spacing between adjacent characters, allowing for automatic control over spacing between different scripts.
[Links (documentation, blog post, etc)]:
https://drafts.csswg.org/css-text-4/#text-autospace-property

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c3c8449fffc0
https://hg.mozilla.org/integration/autoland/rev/aaa062fb966b
Enable layout.css.text-autospace.enabled on Nightly. r=jfkthame,layout-jp-market-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d47eb03be2d5
https://hg.mozilla.org/integration/autoland/rev/0e1982643816
Revert "Bug 1988596 - Enable layout.css.text-autospace.enabled on Nightly. r=jfkthame,layout-jp-market-reviewers" for causing bc failures on browser_test_clipboardcache.js

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for causing bc failures on browser_test_clipboardcache.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/0e1982643816d3c96c5d43f7286c4b0eb9fc166a
Log link: https://treeherder.mozilla.org/logviewer?job_id=527575650&repo=autoland&task=f-DfPxRAToCOdMRs5pqsvw.0&lineNumber=5980

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 8

[Jonathan Kew [:jfkthame]]

I think we may just need to increase the timeout for browser_test_clipboardcache.js. I've pushed a try job to see if this helps:
https://treeherder.mozilla.org/jobs?repo=try&revision=ec90b40d78e33f32ac692bb60dd5fdcdaed05959

Comment 9

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

(In reply to Jonathan Kew [:jfkthame] from comment #8)

I think we may just need to increase the timeout for browser_test_clipboardcache.js. I've pushed a try job to see if this helps:
https://treeherder.mozilla.org/jobs?repo=try&revision=ec90b40d78e33f32ac692bb60dd5fdcdaed05959

There are other oranges in this try run. It is unclear to me if they are related after enabling text-autospace.

Comment 10

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

https://phabricator.services.mozilla.com/D264863 does not include any wpt test to upstream.

Comment 11

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Try run (this bug + bug 1989128):
https://treeherder.mozilla.org/jobs?repo=try&revision=6cd4210ed9d05528870a14dec5169d35763c1f0c
https://treeherder.mozilla.org/jobs?repo=try&revision=aca1a00721ed24c91601122d3236342e810ace60

Comment 12

[Florin Bilt]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c3c8449fffc0
https://hg.mozilla.org/integration/autoland/rev/aaa062fb966b
Enable layout.css.text-autospace.enabled on Nightly.
r=jfkthame,layout-jp-market-reviewers

Perfherder has detected a build_metrics performance change from push aaa062fb966ba6abd9398e2ca4d0173916cdbc25.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	build times	linux64-shippable	nightly taskcluster-projects/970387039909/machineTypes/c3d-standard-60-lssd	3,189.31 -> 3,039.85
2%	installer size	linux64-shippable	nightly	88,219,467.00 -> 86,196,084.33

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 46840

The following documentation link provides more information about this command.

Comment 13

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

In this try run, bug 1989128 appears to prevent the browser_test_clipboardcache.js timeout (bc32 on Linux 24.04 tsan). I'll reland the patch. If it still times out permanently like comment 6, we can use a longer timeout as suggested in comment 8.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1a1d4462e4e4
https://hg.mozilla.org/integration/autoland/rev/ff7bf296a64e
Enable layout.css.text-autospace.enabled on Nightly. r=jfkthame,layout-jp-market-reviewers

Comment 15

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Note to Sheriffs: Enabling text-autospace is known to cause performance regressions in the Talos perf_reftest_singletons suite, especially svg-text-textLength-1.html. This is tracked in bug 1987997, which is expected to mitigate the performance regressions.

Comment 16

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ff7bf296a64e

Comment 17

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Note added to out 145 nightly release notes with this wording:

Starting with Firefox 145, the text-autospace property is supported, allowing automatic spacing adjustments between characters from different scripts.

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55193 for changes under testing/web-platform/tests

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 20

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Removing the nightly+ relnote keyword and removing from 146 nightly release notes as this feature was uplifted to beta in bug 1981086.

Comment 21

[Brian Thomas Smith [:bsmth]]

Also noted in bug 1981086, but adding here for visibility -> MDN docs changes can be tracked in the following GitHub issue https://github.com/mdn/content/issues/41501