Closed
Bug 1988863
Opened 3 months ago
Closed 2 months ago
Add a Stylelint rule to enforce using text-color tokens
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox146 fixed)
RESOLVED
FIXED
146 Branch
| Tracking | Status | |
|---|---|---|
| firefox146 | --- | fixed |
People
(Reporter: hjones, Assigned: dwhisman)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [recomp][acorntractors])
Attachments
(1 file)
We should add a Stylelint rule to enforce only using --text-color* tokens for any color properties in CSS and SCSS files. Since we tend to have so many different legacy/hardcoded color values in the app I wouldn't expect this rule to be autofixable. This work will include documentation, tests, and adding an entry to our rollouts file, but will not include expanding our token offerings or fixing any existing errors.
|
||
Updated•3 months ago
|
|
Assignee | |
Updated•3 months ago
|
Assignee: nobody → dwhisman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 months ago
|
||
|
||
Updated•2 months ago
|
Attachment #9519077 -
Attachment description: WIP: Bug 1988863 - Add a Stylelint rule to enforce using text-color tokens r=#reusable-components-reviewers-rotation → Bug 1988863 - Add a Stylelint rule to enforce using text-color tokens r=#reusable-components-reviewers-rotation
Pushed by jooliver@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/b0c5a2223b93
https://hg.mozilla.org/integration/autoland/rev/a7b3a6ca5454
Add a Stylelint rule to enforce using text-color tokens r=frontend-codestyle-reviewers,hjones
|
||
Comment 3•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox146:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•