1988860 - Add a Stylelint rule to enforce using size tokens

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Hanna Jones [:hjones]]

We should add a Stylelint rule to enforce only using --size-* tokens for any height, width, min-height, min-width, and maybe even background-size (?) properties in CSS and SCSS files. This rule is likely autofixable. This work will include documentation, tests, and adding an entry to our rollouts file, but will not include expanding our token offerings or fixing any existing errors.

Comment 1

[oarnesto]

Attachment: Bug 1988860 - stylelint rule to enforce using size design tokens r=#reusable-components-reviewers-rotation

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2b75d601c974
https://hg.mozilla.org/integration/autoland/rev/e9a25ec36cac
stylelint rule to enforce using size design tokens r=frontend-codestyle-reviewers,akulyk,Gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d7920d565f5
https://hg.mozilla.org/integration/autoland/rev/9a6257287823
Revert "Bug 1988860 - stylelint rule to enforce using size design tokens r=frontend-codestyle-reviewers,akulyk,Gijs" for causing stylelint failures.

Comment 4

[Atila Butkovits]

Backed out for causing stylelint failures.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/9a6257287823a92435bb91a4b4398c5f8078ede7

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e9a25ec36cac93d3378826468f81b4255ed810b1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=534212588&repo=autoland&task=OlmGeHUUSMewdRMaP8JW4Q.0&lineNumber=363

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7da164f64ec
https://hg.mozilla.org/integration/autoland/rev/4933f1406d6a
stylelint rule to enforce using size design tokens r=frontend-codestyle-reviewers,akulyk,Gijs

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4933f1406d6a