1988865 - Fill in our scale of border-color tokens

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Hanna Jones [:hjones]]

Once we've added a linting rule for border-color tokens in bug 1979118, we should be able to use it to generate a list of all the values currently in use in the app that aren't design tokens. There's a sample script in bug 1979120 that should be useful. Once we have the list of values we can consult with UX to see which, if any, of them we want to have as tokens.

Comment 3

[Dustin Whisman [:dwhisman]]

Attachment: Bug 1988865 - Part 1: Add token for border-color-selected r=#reusable-components-reviewers-rotation

Comment 4

[Dustin Whisman [:dwhisman]]

Attachment: Bug 1988865 - Part 2: Use `--border-color-selected` instead of `--color-accent-primary` r=#reusable-components-reviewers-rotation

Comment 5

[Dustin Whisman [:dwhisman]]

Attachment: Bug 1988865 - Part 3: Use `--border-color` instead of `--in-content-border-color` r=#reusable-components-reviewers-rotation

Comment 6

[Dustin Whisman [:dwhisman]]

Attachment: Bug 1988865 - Part 4: Use `--border-color` instead of `--in-content-box-border-color` r=#reusable-components-reviewers-rotation

Comment 7

[Dustin Whisman [:dwhisman]]

Attachment: Bug 1988865 - Part 5: Allow black and white keywords for border colors r=#reusable-components-reviewers-rotation

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c7cdc0660d91
https://hg.mozilla.org/integration/autoland/rev/b1182adc4816
Part 1: Add token for border-color-selected r=mtigley,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,nchevobbe,hjones
https://github.com/mozilla-firefox/firefox/commit/58d47b7292c5
https://hg.mozilla.org/integration/autoland/rev/2f8388cde0e3
Part 2: Use `--border-color-selected` instead of `--color-accent-primary` r=mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,tabbrowser-reviewers,omc-reviewers,home-newtab-reviewers,emcminn,sthompson,robwu,hjones,mconley
https://github.com/mozilla-firefox/firefox/commit/cfc31d69b7f1
https://hg.mozilla.org/integration/autoland/rev/2829c07e2466
Part 3: Use `--border-color` instead of `--in-content-border-color` r=mtigley,webcompat-reviewers,extension-reviewers,credential-management-reviewers,webrtc-reviewers,devtools-reviewers,desktop-theme-reviewers,omc-reviewers,toolkit-telemetry-reviewers,twisniewski,janerik,nchevobbe,mimi,robwu,hjones,ng
https://github.com/mozilla-firefox/firefox/commit/8ee8d43fcb3d
https://hg.mozilla.org/integration/autoland/rev/4b83f713ca7c
Part 4: Use `--border-color` instead of `--in-content-box-border-color` r=mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,webrtc-reviewers,omc-reviewers,toolkit-telemetry-reviewers,janerik,devtools-reviewers,hjones,nchevobbe,mimi,ng,willdurand
https://github.com/mozilla-firefox/firefox/commit/6fd4bc72d793
https://hg.mozilla.org/integration/autoland/rev/b8ec5eeeda12
Part 5: Allow black and white keywords for border colors r=frontend-codestyle-reviewers,hjones

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5f2497f796b8
https://hg.mozilla.org/integration/autoland/rev/aa2009b27613
Revert "Bug 1988865 - Part 5: Allow black and white keywords for border colors r=frontend-codestyle-reviewers,hjones" for causing dt failures on /browser_parsable_css.js

Comment 10

[Cristina Horotan [:chorotan]]

Backed out for causing dt failures on /browser_parsable_css.js

Backout link

Push with failures

Failure log

Comment 11

[Dustin Whisman [:dwhisman]]

Resolved issues with locally declared CSS variables being unused.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/768595ac6fdc
https://hg.mozilla.org/integration/autoland/rev/6893301b4ace
Part 1: Add token for border-color-selected r=mtigley,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,nchevobbe,hjones
https://github.com/mozilla-firefox/firefox/commit/f464a04e5571
https://hg.mozilla.org/integration/autoland/rev/bc5ceec0964a
Part 2: Use `--border-color-selected` instead of `--color-accent-primary` r=mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,tabbrowser-reviewers,omc-reviewers,home-newtab-reviewers,emcminn,sthompson,robwu,hjones,mconley
https://github.com/mozilla-firefox/firefox/commit/81635b4f708f
https://hg.mozilla.org/integration/autoland/rev/17a8736d4035
Part 3: Use `--border-color` instead of `--in-content-border-color` r=mtigley,webcompat-reviewers,extension-reviewers,credential-management-reviewers,webrtc-reviewers,devtools-reviewers,desktop-theme-reviewers,omc-reviewers,toolkit-telemetry-reviewers,twisniewski,janerik,nchevobbe,mimi,robwu,hjones,ng
https://github.com/mozilla-firefox/firefox/commit/0f6413dbbdc8
https://hg.mozilla.org/integration/autoland/rev/4a98dfa6e531
Part 4: Use `--border-color` instead of `--in-content-box-border-color` r=mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,webrtc-reviewers,omc-reviewers,toolkit-telemetry-reviewers,janerik,devtools-reviewers,hjones,nchevobbe,mimi,ng,willdurand
https://github.com/mozilla-firefox/firefox/commit/926822686bfc
https://hg.mozilla.org/integration/autoland/rev/02452d38b61f
Part 5: Allow black and white keywords for border colors r=frontend-codestyle-reviewers,hjones

Comment 13

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6893301b4ace
https://hg.mozilla.org/mozilla-central/rev/bc5ceec0964a
https://hg.mozilla.org/mozilla-central/rev/17a8736d4035
https://hg.mozilla.org/mozilla-central/rev/4a98dfa6e531
https://hg.mozilla.org/mozilla-central/rev/02452d38b61f