1988871 - Fill in our scale of size tokens

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Hanna Jones [:hjones]]

Once we've added a linting rule for size tokens in bug 1988860, we should be able to use it to generate a list of all the values currently in use in the app that aren't design tokens. There's a sample script in bug 1979120 that should be useful. Once we have the list of values we can consult with UX to see which, if any, of them we want to have as tokens.

Comment 1

[Dustin Whisman [:dwhisman]]

Attachment: WIP: Bug 1988871 - Fill in our scale of size tokens r=#reusable-components-reviewers-rotation

Comment 2

[Dustin Whisman [:dwhisman]]

Attachment: Bug 1988871 - Add image and layout size tokens r=jules

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4d61e7009851
https://hg.mozilla.org/integration/autoland/rev/9eb7cf9f2b89
Add image and layout size tokens r=jules,mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,toolkit-telemetry-reviewers-rotation,nsharpley,willdurand

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9af55f4dd33d
https://hg.mozilla.org/integration/autoland/rev/0e12cc1c85d1
Revert "Bug 1988871, Bug 2005767 - Add image and layout size tokens r=jules,mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,toolkit-telemetry-reviewers-rotation,nsharpley,willdurand" for causing mochitests failures in browser_aboutCertError_telemetry.js.

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing mochitests failures

Backout link

Push with failures

Failure log
Failure log
Failure log

Comment 6

[Dustin Whisman [:dwhisman]]

A similar issue appeared in 2005767, and I applied a similar fix in that upstream patch, so this should be resolved.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a93a3d6e9ad0
https://hg.mozilla.org/integration/autoland/rev/7e88554afae9
Add image and layout size tokens r=jules,mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,nsharpley,willdurand

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20c84feb6192
https://hg.mozilla.org/integration/autoland/rev/66700a891d79
Revert "Bug 1988871, Bug 2005767 - Add image and layout size tokens r=jules,mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,nsharpley,willdurand" for causing bc failures on browser_parsable_css.js

Comment 9

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on browser_parsable_css.js

Backout link

Push with failures

Failure log browser_parsable_css.js
Failure log test_contextmenu_list.xhtml

Comment 10

[Dustin Whisman [:dwhisman]]

The browser_parsable_css test should be fixed by using CSS vars in a Windows-specific file that roughly mirrors the macos file with the same change, and the test_contextmenu_list test should be fixed by modifying the logic to be a little more lenient with pixel measurements, since the rem-based calculations are different with the new tokens.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e43fbf705313
https://hg.mozilla.org/integration/autoland/rev/ffda3d67e12f
Add image and layout size tokens r=jules,mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,nsharpley,willdurand

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c93194644fee
https://hg.mozilla.org/integration/autoland/rev/94d3b8be5719
Revert "Bug 1988871, Bug 2005767 - Add image and layout size tokens r=jules,mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,nsharpley,willdurand" for causing mochitests failures in test_popup_coords.xhtml.

Comment 13

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in test_popup_coords.xhtml.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_popup_coords.xhtml | popupshowing on outerpopup clientX - got 11, expected 10

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ae65f987ffc
https://hg.mozilla.org/integration/autoland/rev/f8ec2d38c343
Add image and layout size tokens r=jules,mtigley,extension-reviewers,desktop-theme-reviewers,credential-management-reviewers,nsharpley,willdurand

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f8ec2d38c343

Comment 16

[Dustin Whisman [:dwhisman]]

All the failing tests are fixed.