Closed Bug 1989205 Opened 6 months ago Closed 6 months ago

Permafail across trees TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | Test timed out -

Categories

(Toolkit :: Add-ons Manager, defect)

defect

Tracking

()

RESOLVED FIXED
145 Branch
Tracking Status
firefox-esr115 --- fixed
firefox-esr140 --- fixed
firefox143 --- fixed
firefox144 --- fixed
firefox145 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: willdurand)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [collect_confirm_failure][addons-jira][stockwell needswork:owner])

Attachments

(2 files)

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=527550262&repo=autoland&task=fa9HMji6TPKeCXuMQK0KEw.0
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fa9HMji6TPKeCXuMQK0KEw/runs/0/artifacts/public/logs/live_backing.log


[task 2025-09-18T05:25:43.132+00:00] 05:25:43     INFO - TEST-PASS | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | Should be no active installs - 
[task 2025-09-18T05:25:43.133+00:00] 05:25:43     INFO - Waiting for addon-webext-permissions notification
[task 2025-09-18T05:25:43.134+00:00] 05:25:43     INFO - Observed addon-install-started for 1 installs
[task 2025-09-18T05:25:43.134+00:00] 05:25:43     INFO - Install of http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/recommended.xpi was in state 0
[task 2025-09-18T05:25:43.135+00:00] 05:25:43     INFO - Console message: 1758172960115	addons.manager	INFO	Addon download before validation.
[task 2025-09-18T05:25:43.136+00:00] 05:25:43     INFO - Console message: 1758172960132	addons.xpi	DEBUG	Download started for http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/recommended.xpi to file C:\Users\task_175817143829905\AppData\Local\Temp\tmp-dup.xpi
[task 2025-09-18T05:25:43.136+00:00] 05:25:43     INFO - Console message: 1758172960133	addons.xpi	DEBUG	Download of http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/recommended.xpi completed.
[task 2025-09-18T05:25:43.136+00:00] 05:25:43     INFO - Observed addon-install-blocked for 1 installs
[task 2025-09-18T05:25:43.137+00:00] 05:25:43     INFO - Install of http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/recommended.xpi was in state 3
[task 2025-09-18T05:25:43.137+00:00] 05:25:43     INFO - Console message: 1758172960144	addons.repository	DEBUG	cacheAddons: enabled false IDs ["{811d77f1-f306-4187-9251-b4ff99bad60b}"]
[task 2025-09-18T05:25:43.138+00:00] 05:25:43     INFO - Buffered messages logged at 05:22:55
[task 2025-09-18T05:25:43.138+00:00] 05:25:43     INFO - Console message: 1758172975323	addons.manager	DEBUG	Background update check beginning
[task 2025-09-18T05:25:43.139+00:00] 05:25:43     INFO - Console message: 1758172975323	addons.manager	DEBUG	Background update check complete
[task 2025-09-18T05:25:43.139+00:00] 05:25:43     INFO - Buffered messages logged at 05:23:27
[task 2025-09-18T05:25:43.139+00:00] 05:25:43     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 3
[task 2025-09-18T05:25:43.140+00:00] 05:25:43     INFO - Buffered messages logged at 05:24:12
[task 2025-09-18T05:25:43.140+00:00] 05:25:43     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 2
[task 2025-09-18T05:25:43.141+00:00] 05:25:43     INFO - Buffered messages logged at 05:24:57
[task 2025-09-18T05:25:43.141+00:00] 05:25:43     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
[task 2025-09-18T05:25:43.142+00:00] 05:25:43     INFO - Buffered messages finished
[task 2025-09-18T05:25:43.142+00:00] 05:25:43     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | Test timed out - 
[task 2025-09-18T05:25:43.142+00:00] 05:25:43     INFO - GECKO(2628) | Completed ShutdownLeaks collections in process 2096
[task 2025-09-18T05:25:43.143+00:00] 05:25:43     INFO - TEST-START | Shutdown
[task 2025-09-18T05:25:43.143+00:00] 05:25:43     INFO - Browser Chrome Test Summary
[task 2025-09-18T05:25:43.144+00:00] 05:25:43     INFO - Passed:  126
[task 2025-09-18T05:25:43.144+00:00] 05:25:43     INFO - Failed:  1
[task 2025-09-18T05:25:43.145+00:00] 05:25:43     INFO - Todo:    0
[task 2025-09-18T05:25:43.145+00:00] 05:25:43     INFO - Mode:    e10s
[task 2025-09-18T05:25:43.146+00:00] 05:25:43     INFO - *** End BrowserChrome Test Results ***
[task 2025-09-18T05:25:43.146+00:00] 05:25:43     INFO - GECKO(2628) | Exiting due to channel error.
[task 2025-09-18T05:25:43.146+00:00] 05:25:43     INFO - GECKO(2628) | Exiting due to channel error.
[task 2025-09-18T05:25:43.147+00:00] 05:25:43     INFO - TEST-INFO | Main app process: exit 0
[task 2025-09-18T05:25:43.147+00:00] 05:25:43     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | Application shut down (without crashing) in the middle of a test!
[task 2025-09-18T05:25:43.147+00:00] 05:25:43     INFO - TEST-INFO took 184500ms
[task 2025-09-18T05:25:43.148+00:00] 05:25:43     INFO - runtests.py | Application ran for: 0:03:18.345741

This is permafailing on all platforms except on Android. Couldn't find something relevant about this even after some retriggers and backfills.

Hi Rob! Could you maybe help us finding a possible cause for this one?

Thank you!

Severity: S4 → --
Flags: needinfo?(rob)
Priority: P5 → --

Could a person from your team investigate this permanent failure? It affects at least trunk, beta and release. The recommended.xpi file installs fine locally and the screenshot of such a failing task shows it gets stuck earlier at the install prompt.

Flags: needinfo?(mixedpuppy)
Summary: Perma TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | Test timed out - → Permafail across trees TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | Test timed out -

The failure is due to a time bomb. Recommendations are currently only valid for 5 years, and the test file introduced in bug 1659530 is now past that age.

recommended.xpi is no longer recommended: https://robwu.nl/crxviewer/?crx=https%3A%2F%2Fsearchfox.org%2Ffirefox-main%2Frev%2Fe4d8867f696477f5ec96db70d584716c6edb1213%2Ftoolkit%2Fmozapps%2Fextensions%2Ftest%2Fxpinstall%2Frecommended.xpi&q=!not_after&qf=mozilla-recommendation.json&qb=1&qh=0&qi=1

{
    "addon_id": "{811d77f1-f306-4187-9251-b4ff99bad60b}",
    "states": [
        "line"
    ],
    "validity": {
        "not_after": "2025-09-17T22:50:45Z",
        "not_before": "2020-09-17T16:50:45Z"
    },
    "schema_version": 1
}

If we haven't done so, we should consider switching to the AMO stage cert (context: bug 1886252).

Flags: needinfo?(rob)
Flags: needinfo?(mixedpuppy)
See Also: → 1659530
Whiteboard: [collect_confirm_failure] → [collect_confirm_failure][addons-jira]

Will, do you know how easy it is to get a recommended xpi file on stage? In this case, a line extension.

If difficult, then we can consider faking the recommendation in the test instead.

Flags: needinfo?(wdurand)

The new XPI file has been generated from this PR 1, and signed by the
AMO -dev instance (which uses the nonprod cert). FTR since this add-on
needs a recommendation state, we must add the add-on to the "By Firefox"
promoted group via the AMO admin before getting the version signed.

Before:

$ xpidump old.xpi
MANIFEST:
  ID        : N/A
  Version   : 2.0
  Enterprise: No

RECOMMENDATION:
  [Line]

SIGNATURES:
  PKCS7:
   └── PRESENT / PRODUCTION / SHA-1 / REGULAR ADD-ON
   └── Certificates:
        └── Common Name         (CN): signingca1.addons.mozilla.org
            Organizational Unit (OU): Mozilla AMO Production Signing Service
            End Date                : 2025-04-04T00:00:00Z
        └── Common Name         (CN): {811d77f1-f306-4187-9251-b4ff99bad60b}
            Organizational Unit (OU): Production
            End Date                : 2030-09-15T16:50:45Z
  COSE:
   └── PRESENT / PRODUCTION / ES256 / REGULAR ADD-ON
   └── Certificates:
        └── Common Name         (CN): signingca1.addons.mozilla.org
            Organizational Unit (OU): Mozilla AMO Production Signing Service
            End Date                : 2025-04-04T00:00:00Z
        └── Common Name         (CN): {811d77f1-f306-4187-9251-b4ff99bad60b}
            Organizational Unit (OU): Production
            End Date                : 2030-09-15T16:50:45Z

After:

$ xpidump new.xpi
MANIFEST:
  ID        : recommended-line@test.mozilla.org
  Version   : 3.0
  Enterprise: No

RECOMMENDATION:
  [Line]

SIGNATURES:
  PKCS7:
   └── PRESENT / STAGING / SHA-256 / REGULAR ADD-ON
   └── Certificates:
        └── Common Name         (CN): cas-intermediate-amo-ca-staging
            Organizational Unit (OU): Mozilla Staging Signing Service
            End Date                : 2050-12-31T00:00:00Z
        └── Common Name         (CN): recommended-line@test.mozilla.org
            Organizational Unit (OU): Production
            End Date                : 2035-09-17T07:29:49Z
  COSE:
   └── PRESENT / STAGING / ES256 / REGULAR ADD-ON
   └── Certificates:
        └── Common Name         (CN): cas-intermediate-amo-ca-staging
            Organizational Unit (OU): Mozilla Staging Signing Service
            End Date                : 2050-12-31T00:00:00Z
        └── Common Name         (CN): recommended-line@test.mozilla.org
            Organizational Unit (OU): Production
            End Date                : 2035-09-17T07:29:49Z
Assignee: nobody → wdurand
Status: NEW → ASSIGNED
Flags: needinfo?(wdurand)

I verified that this recommended.xpi file is the only xpi file with the mozilla-recommendation.json metadata file in the tree:

$ find . -name '*.xpi' | grep -v objdir- | while read line ; do [[ "$(zipinfo "$line" 2>/dev/null)" == *"mozilla-recommendation.json"* ]] && echo $line ; done
./toolkit/mozapps/extensions/test/xpinstall/recommended.xpi

Comment on attachment 9514249 [details]
Bug 1989205 - Update recommended.xpi file to fix a test (permafailure). r?robwu!

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: None (it's a test-only change).
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch replaces an XPI in tree to fix a permafailure. It can only get better...
  • String changes made/needed: N/A
  • Is Android affected?: Yes
Attachment #9514249 - Flags: approval-mozilla-release?
Attachment #9514249 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch

Comment on attachment 9514249 [details]
Bug 1989205 - Update recommended.xpi file to fix a test (permafailure). r?robwu!

Approved for 144.0b4

Attachment #9514249 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

The new XPI file has been generated from this PR 1, and signed by the
AMO -dev instance (which uses the nonprod cert). FTR since this add-on
needs a recommendation state, we must add the add-on to the "By Firefox"
promoted group via the AMO admin before getting the version signed.

Before:

$ xpidump old.xpi
MANIFEST:
  ID        : N/A
  Version   : 2.0
  Enterprise: No

RECOMMENDATION:
  [Line]

SIGNATURES:
  PKCS7:
    └── PRESENT / PRODUCTION / SHA-1 / REGULAR ADD-ON
    └── Certificates:
	└── Common Name         (CN): signingca1.addons.mozilla.org
	    Organizational Unit (OU): Mozilla AMO Production Signing Service
	    End Date                : 2025-04-04T00:00:00Z
	└── Common Name         (CN): {811d77f1-f306-4187-9251-b4ff99bad60b}
	    Organizational Unit (OU): Production
	    End Date                : 2030-09-15T16:50:45Z
  COSE:
    └── PRESENT / PRODUCTION / ES256 / REGULAR ADD-ON
    └── Certificates:
	└── Common Name         (CN): signingca1.addons.mozilla.org
	    Organizational Unit (OU): Mozilla AMO Production Signing Service
	    End Date                : 2025-04-04T00:00:00Z
	└── Common Name         (CN): {811d77f1-f306-4187-9251-b4ff99bad60b}
	    Organizational Unit (OU): Production
	    End Date                : 2030-09-15T16:50:45Z

After:

$ xpidump new.xpi
MANIFEST:
  ID        : recommended-line@test.mozilla.org
  Version   : 3.0
  Enterprise: No

RECOMMENDATION:
  [Line]

SIGNATURES:
  PKCS7:
    └── PRESENT / STAGING / SHA-256 / REGULAR ADD-ON
    └── Certificates:
	└── Common Name         (CN): cas-intermediate-amo-ca-staging
	    Organizational Unit (OU): Mozilla Staging Signing Service
	    End Date                : 2050-12-31T00:00:00Z
	└── Common Name         (CN): recommended-line@test.mozilla.org
	    Organizational Unit (OU): Production
	    End Date                : 2035-09-17T07:29:49Z
  COSE:
    └── PRESENT / STAGING / ES256 / REGULAR ADD-ON
    └── Certificates:
	└── Common Name         (CN): cas-intermediate-amo-ca-staging
	    Organizational Unit (OU): Mozilla Staging Signing Service
	    End Date                : 2050-12-31T00:00:00Z
	└── Common Name         (CN): recommended-line@test.mozilla.org
	    Organizational Unit (OU): Production
	    End Date                : 2035-09-17T07:29:49Z
Attachment #9514638 - Flags: approval-mozilla-release?

Comment on attachment 9514638 [details]
Bug 1989205 - Update recommended.xpi file to fix a test (permafailure) for ESR. r?robwu!

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes permafail
  • User impact if declined: None
  • Fix Landed on Version: 145, uplifted to beta (and pending uplift to release)
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Test-only fix of test that already permafails (timeout).
Attachment #9514638 - Flags: approval-mozilla-release?
Attachment #9514638 - Flags: approval-mozilla-esr140?
Attachment #9514638 - Flags: approval-mozilla-esr115?

Comment on attachment 9514249 [details]
Bug 1989205 - Update recommended.xpi file to fix a test (permafailure). r?robwu!

test-only fix, approved for 143.0.3

Attachment #9514249 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9514638 - Flags: approval-mozilla-esr140? → approval-mozilla-esr140+

Comment on attachment 9514638 [details]
Bug 1989205 - Update recommended.xpi file to fix a test (permafailure) for ESR. r?robwu!

Approved for 115.29esr.

Attachment #9514638 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
QA Whiteboard: [qa-triage-done-c145/b144]
See Also: → 1996059
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: