1989304 - The comment dialog is spilling out of the viewport when the dialog is opened at the edge of the viewport

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Raluca Popovici, Desktop QA]

Attachment: Screenshot 2025-09-18 at 16.27.12.png

Found in:
Nightly 145.0a1(2025-09-18)

Affected versions:
Nightly 145.0a1(2025-09-18)

Tested platforms:

Affected platforms: macOS 13.2.1, Ubuntu 24.10, Windows 10
Unaffected platforms:

Steps to reproduce:

1. Load a PDF
2. Select any length of text at the edge of the viewport/window.
3. Click the "Comment" button under the text selection.

Expected result:
The 'Add Comment' dialog is displayed in the viewport regardless of window size.

Actual result:
When the dialog is opened at the edge of the viewport(window), the 'Add Comment' dialog spills out of the viewport. Please see the screenshot.

Regression range:
This is not a regression; it is a bug related to the new implementation of the PDF comments.

Additional notes:
The 'Add Comment' box should remain properly positioned when the browser is resized. The user should not scroll the page to reach 'Save'
button or the 'Add comment' dialog to be fully visible.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Make sure the comment dialog is visible on the screen (bug 1989304) (#20283)

Comment 2

[Raluca Popovici, Desktop QA]

Attachment: Screen Recording 2025-10-02 at 17.27.19 (2).mp4

Comment 3

[Raluca Popovici, Desktop QA]

Verified on the latest Nightly 145.0a1 (2025-10-02). Sometimes, when the Firefox window is resized, highlighting text on the left side of the PDF and opening the 'Add Comment' dialog causes the dialog to disappear after resizing the window again. When this happens, I can’t scroll the PDF to the left to bring the dialog back into view. Please see the attached screen recording.
Do you think we should reopen this issue or log another one?

Comment 4

[Calixte Denizet (:calixte)]

It isn't easy to reproduce but I managed too.
Could you file a new bug please ?

Comment 5

[Raluca Popovici, Desktop QA]

Hello Calixte,
I reported a new issue for this: https://bugzilla.mozilla.org/show_bug.cgi?id=1992358

Comment 6

[Raluca Popovici, Desktop QA]

Verified as fixed in Nightly 145(2025-10-02) using MacOS 13.2.1, Windows 11 and Ubuntu 24.