Closed Bug 2039755 Opened 2 months ago Closed 2 months ago

Update PDF.js to new version cd4fd7563c310e8625f407bb208aa19b0506b598 from 2026-05-14 20:11:06

Categories

(Firefox :: PDF Viewer, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
152 Branch
Tracking Status
firefox152 --- fixed

People

(Reporter: update-bot, Assigned: calixte)

References

(Blocks 1 open bug)

Details

(Whiteboard: [3pl-filed][task_id: fC1dBrK8SJCGA-3ryXrPwQ])

Attachments

(1 file)

This update covers 7 commits. Here are the overall diff statistics, and then the commit information.


toolkit/components/pdfjs/content/build/pdf.mjs | 30 ++++-----
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 19 +-----
toolkit/components/pdfjs/content/web/iccs/CGATS001Compat-v2-micro.icc | 0
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 10 ---
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 7 +-
toolkit/components/pdfjs/content/web/viewer.css | 10 ---
toolkit/components/pdfjs/content/web/viewer.mjs | 7 +-
toolkit/components/pdfjs/moz.yaml | 4 +-
9 files changed, 30 insertions(+), 61 deletions(-)


195bfdcfbdd9893b1ed6a09c0e6beaabd2db573b by calixteman <calixte.denizet@gmail.com>

https://github.com/mozilla/pdf.js/commit/195bfdcfbdd9893b1ed6a09c0e6beaabd2db573b
Authored: 2026-05-14 18:13:05 +0200
Committed: 2026-05-14 18:13:11 +0200

Enable Codecov flag carryforward for accurate coverage badge

It fixes #21273.

Files Added:

  • codecov.yml

949497a3c4291a2be031f7df69ade0e33d1e6a30 by Jonas Jenwald <jonas.jenwald@gmail.com>

https://github.com/mozilla/pdf.js/commit/949497a3c4291a2be031f7df69ade0e33d1e6a30
Authored: 2026-05-14 15:34:38 +0200
Committed: 2026-05-14 15:44:42 +0200

Add a simple API unit-test for /BrotliDecode

This is a new feature in PDF documents, hence it shouldn't hurt to complement the existing ref-test with a simple unit-test as well.
This should also improve test coverage for the external/ folder, which can't hurt since the other external decoders are already fairly well covered.

Files Modified:

  • test/unit/api_spec.js

16d82e094f6bd64cb7d80c1defc5437b5f4fb51c by Roland Arnold <rolandwarnold@gmail.com>

https://github.com/mozilla/pdf.js/commit/16d82e094f6bd64cb7d80c1defc5437b5f4fb51c
Authored: 2026-05-03 18:30:40 +0100
Committed: 2026-05-14 14:28:41 +0100

fix: inline styles for hidden helper elements

Set layout-neutral styles at the creation sites for the hidden TextLayer
canvas and PDFViewer copy element rather than relying on the shared
web/pdf_viewer.css rule.

This keeps the helper elements invisible and out of layout when viewer CSS
selectors are scoped or omitted, and removes the obsolete hiddenCanvasElement
class and shared CSS rule.

Files Modified:

  • src/display/text_layer.js
  • web/pdf_viewer.css
  • web/pdf_viewer.js

f8f497a03aaebcb339c502fb805447b35e549482 by Calixte Denizet <calixte.denizet@gmail.com>

https://github.com/mozilla/pdf.js/commit/f8f497a03aaebcb339c502fb805447b35e549482
Authored: 2026-05-12 22:28:56 +0200
Committed: 2026-05-14 13:55:14 +0200

Add a lint-chmod task to catch stray executable bits

Files Modified:

  • external/iccs/CGATS001Compat-v2-micro.icc
  • gulpfile.mjs
  • test/images/samplesignature.png

26dc195a65f5a42801088705163521155ed0199d by Tim van der Meij <timvandermeij@gmail.com>

https://github.com/mozilla/pdf.js/commit/26dc195a65f5a42801088705163521155ed0199d
Authored: 2026-04-27 15:29:54 +0200
Committed: 2026-05-14 12:34:12 +0200

Collect coverage information for the integration tests

Note that for the integration tests the coverage information ends up
being processed in the Node.js context where window is not available,
so we use globalThis instead for the function that merges individual
test's coverage information into the global object because that is
available in all contexts we support. For clarity we also rename said
function since we're not exclusively dealing with window nor worker
data anymore.

Files Modified:

  • .github/workflows/integration_tests.yml
  • src/core/worker.js
  • test/coverage_utils.js
  • test/integration/test_utils.mjs
  • test/test.mjs
  • test/unit/jasmine-boot.js

204f9203bd1c6a3429616f3bb8abb4a131e4df30 by Jonas Jenwald <jonas.jenwald@gmail.com>

https://github.com/mozilla/pdf.js/commit/204f9203bd1c6a3429616f3bb8abb4a131e4df30
Authored: 2026-05-14 12:21:36 +0200
Committed: 2026-05-14 12:21:36 +0200

Avoid bundling DOM-related code in the built pdf.worker.mjs file

Currently the isCanvasFilterSupported/isAlphaColorInputSupported getters, on the FeatureTest class, contains code that cannot run in the worker-thread since it relies on the DOM being available.
To avoid that a new DEFINE is added, in gulpfile.mjs, to allow skipping this sort of dead code in the built pdf.worker.mjs file.

Files Modified:

  • gulpfile.mjs
  • src/shared/util.js

41e47c8b6ffaca5c01a15809d6fc5833b96b3554 by Tim van der Meij <timvandermeij@gmail.com>

https://github.com/mozilla/pdf.js/commit/41e47c8b6ffaca5c01a15809d6fc5833b96b3554
Authored: 2026-05-12 20:53:52 +0200
Committed: 2026-05-12 20:59:07 +0200

Remove the executable bit from test PDF files

Test PDF files should never be executable because we only read their
contents, so this commit makes sure that all test PDFs have the same
permissions, namely 0644 (read-only for all groups, and writable for the
owner), to limit their permissions for a least-privilege approach.

Files Modified:

  • test/pdfs/ThuluthFeatures.pdf
  • test/pdfs/acroform_calculation_order.pdf
  • test/pdfs/annotation-freetext.pdf
  • test/pdfs/annotation-line.pdf
  • test/pdfs/annotation-polyline-polygon.pdf
  • test/pdfs/annotation-square-circle.pdf
  • test/pdfs/autoprint.pdf
  • test/pdfs/bomb_giant.pdf
  • test/pdfs/bug1539074.1.pdf
  • test/pdfs/bug1539074.pdf
  • test/pdfs/bug1669097.pdf
  • test/pdfs/bug1675139.pdf
  • test/pdfs/bug1708040.pdf
  • test/pdfs/bug1724918.pdf
  • test/pdfs/bug1770750.pdf
  • test/pdfs/bug1782186.pdf
  • test/pdfs/bug1782564.pdf
  • test/pdfs/bug1796741.pdf
  • test/pdfs/bug1802888.pdf
  • test/pdfs/bug1811510.pdf
  • test/pdfs/bug1811694.pdf
  • test/pdfs/bug1815476.pdf
  • test/pdfs/bug1820909.1.pdf
  • test/pdfs/bug1825002.pdf
  • test/pdfs/bug1844576.pdf
  • test/pdfs/bug1844583.pdf
  • test/pdfs/bug1851498.pdf
  • test/pdfs/bug1863910.pdf
  • test/pdfs/bug1865341.pdf
  • test/pdfs/bug1868759.pdf
  • test/pdfs/bug1872721.pdf
  • test/pdfs/bug1883609.pdf
  • test/pdfs/bug1885505.pdf
  • test/pdfs/bug1918115.pdf
  • test/pdfs/bug1919513.pdf
  • test/pdfs/bug1922766.pdf
  • test/pdfs/bug1934157.pdf
  • test/pdfs/bug1937438_af_from_latex.pdf
  • test/pdfs/bug1937438_from_word.pdf
  • test/pdfs/bug1937438_mml_from_latex.pdf
  • test/pdfs/bug1963407.pdf
  • test/pdfs/bug1974436.pdf
  • test/pdfs/bug1978317.pdf
  • test/pdfs/bug1989304.pdf
  • test/pdfs/bug1992868.pdf
  • test/pdfs/bug1997343.pdf
  • test/pdfs/bug2004951.pdf
  • test/pdfs/bug2009627.pdf
  • test/pdfs/bug2014080.pdf
  • test/pdfs/bug2026037.pdf
  • test/pdfs/copy_paste_ligatures.pdf
  • test/pdfs/dates.pdf
  • test/pdfs/dates_save.pdf
  • test/pdfs/doc_1_3_pages.pdf
  • test/pdfs/doc_2_3_pages.pdf
  • test/pdfs/doc_3_3_pages.pdf
  • test/pdfs/empty#hash.pdf
  • test/pdfs/empty.pdf
  • test/pdfs/empty_protected.pdf
  • test/pdfs/extract_link.pdf
  • test/pdfs/fields_order.pdf
  • test/pdfs/file_pdfjs_form.pdf
  • test/pdfs/file_pdfjs_test.pdf
  • test/pdfs/firefox_logo.pdf
  • test/pdfs/font_ascent_descent.pdf
  • test/pdfs/freetext_no_appearance.pdf
  • test/pdfs/freetexts.pdf
  • test/pdfs/highlight.pdf
  • test/pdfs/highlight_popup.pdf
  • test/pdfs/highlights.pdf
  • test/pdfs/issue12213.pdf
  • test/pdfs/issue13211.pdf
  • test/pdfs/issue14497.pdf
  • test/pdfs/issue14502.pdf
  • test/pdfs/issue14627.pdf
  • test/pdfs/issue14862.pdf
  • test/pdfs/issue15053.pdf
  • test/pdfs/issue15092.pdf
  • test/pdfs/issue15096.pdf
  • test/pdfs/issue15597.pdf
  • test/pdfs/issue15690.pdf
  • test/pdfs/issue15753.pdf
  • test/pdfs/issue15759.pdf
  • test/pdfs/issue15789.pdf
  • test/pdfs/issue15815.pdf
  • test/pdfs/issue15818.pdf
  • test/pdfs/issue16021.pdf
  • test/pdfs/issue16063.pdf
  • test/pdfs/issue16067.pdf
  • test/pdfs/issue16091.pdf
  • test/pdfs/issue16221.pdf
  • test/pdfs/issue16224.pdf
  • test/pdfs/issue16316.pdf
  • test/pdfs/issue16473.pdf
  • test/pdfs/issue16500.pdf
  • test/pdfs/issue16553.pdf
  • test/pdfs/issue16633.pdf
  • test/pdfs/issue17069.pdf
  • test/pdfs/issue17215.pdf
  • test/pdfs/issue17671.pdf
  • test/pdfs/issue17808.pdf
  • test/pdfs/issue17871_bottom_right.pdf
  • test/pdfs/issue17871_top_right.pdf
  • test/pdfs/issue17929.pdf
  • test/pdfs/issue17998.pdf
  • test/pdfs/issue18036.pdf
  • test/pdfs/issue18305.pdf
  • test/pdfs/issue18360.pdf
  • test/pdfs/issue18536.pdf
  • test/pdfs/issue18561.pdf
  • test/pdfs/issue18693.pdf
  • test/pdfs/issue18694.pdf
  • test/pdfs/issue18894.pdf
  • test/pdfs/issue18911.pdf
  • test/pdfs/issue18956.pdf
  • test/pdfs/issue19083.pdf
  • test/pdfs/issue19120.pdf
  • test/pdfs/issue19239.pdf
  • test/pdfs/issue19360.pdf
  • test/pdfs/issue19424.pdf
  • test/pdfs/issue19505.pdf
  • test/pdfs/issue19517.pdf
  • test/pdfs/issue19633.pdf
  • test/pdfs/issue20062.pdf
  • test/pdfs/issue20065.pdf
  • test/pdfs/issue20102.pdf
  • test/pdfs/issue20225.pdf
  • test/pdfs/issue7821.pdf
  • test/pdfs/issue925.pdf
  • test/pdfs/labelled_pages.pdf
  • test/pdfs/multiline.pdf
  • test/pdfs/page_with_number.pdf
  • test/pdfs/page_with_number_and_link.pdf
  • test/pdfs/paragraph_and_link.pdf
  • test/pdfs/pdfjs_wikipedia.pdf
  • test/pdfs/personwithdog.pdf
  • test/pdfs/print_protection.pdf
  • test/pdfs/red_stamp.pdf
  • test/pdfs/rotated_freetexts.pdf
  • test/pdfs/scan-bad.pdf
  • test/pdfs/smaskdim.pdf
  • test/pdfs/stamps.pdf
  • test/pdfs/tagged_stamp.pdf
  • test/pdfs/textfields.pdf
  • test/pdfs/three_pages_with_number.pdf
  • test/pdfs/tiling_patterns_variations.pdf
  • test/pdfs/tracemonkey_annotation_on_page_8.pdf
  • test/pdfs/tracemonkey_freetext.pdf
  • test/pdfs/tracemonkey_with_annotations.pdf
  • test/pdfs/tracemonkey_with_editable_annotations.pdf
  • test/pdfs/two_pages.pdf
  • test/pdfs/two_paragraphs.pdf
  • test/pdfs/type4psfunc.pdf

Duplicate of this bug: 2039668
Assignee: nobody → update-bot
Status: NEW → ASSIGNED

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: update-bot → cdenizet
Pushed by cdenizet@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2d914978fa11 https://hg.mozilla.org/integration/autoland/rev/a0eca59b4f1a Update PDF.js to cd4fd7563c310e8625f407bb208aa19b0506b598 r=pdfjs-reviewers,calixte
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: