Closed
Bug 1989344
Opened 4 months ago
Closed 4 months ago
Adjust interaction cue timing for drag to pin
Categories
(Firefox :: Tabbed Browser, enhancement, P1)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
145 Branch
People
(Reporter: nsharpley, Assigned: nsharpley)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fidefe-sidebar])
Attachments
(3 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-release+
|
Details | Review |
In order to further improve sensitivity issues with the interaction cue, adjust when the timer for the delay starts and is reset, similar to tab group dragover behaviour.
Updated•4 months ago
|
Updated•4 months ago
|
| Assignee | ||
Comment 1•4 months ago
|
||
Updated•4 months ago
|
Attachment #9514314 -
Attachment description: Bug 1989344 - Increase interaction timer delay and reset interaction timer on mouse move r=dao → Bug 1989344 - Increase interaction timer delay, add pref for delayMS and reset interaction timer on mouse move r=dao
Pushed by nsharpley@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/bc8191040577
https://hg.mozilla.org/integration/autoland/rev/fc723939d5d0
Increase interaction timer delay, add pref for delayMS and reset interaction timer on mouse move r=dao,tabbrowser-reviewers
Comment 3•4 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox145:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
Updated•4 months ago
|
status-firefox144:
--- → affected
Depends on: 1984210
| Assignee | ||
Comment 4•4 months ago
|
||
Updated•4 months ago
|
Attachment #9514716 -
Flags: approval-mozilla-beta?
Comment 5•4 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: Unintentional pinning when dragging to the start of the tabstrip with no pins.
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: Have no pinned tabs and try to move a tab to the first position.
- Risk associated with taking this patch: low
- Explanation of risk level: Just adds a pref and a delay to the interaction cue. No other behaviour impact.
- String changes made/needed: N/A
- Is Android affected?: no
Flags: qe-verify+
Comment 6•4 months ago
|
||
[Tracking Requested - why for this release]: Potential dot release candidate but would like QA testing in Nightly/beta to ensure there aren't any unintended side effects.
tracking-firefox143:
--- → ?
Updated•4 months ago
|
Updated•4 months ago
|
Attachment #9514716 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•4 months ago
|
Comment 8•4 months ago
|
||
This issue is verified as fixed in our latest Beta 144.0b5 as well as our latest Nightly build 145.0a1 (2025-09-23), There is a slight delay before the animation to pin tabs hits and it makes it harder for users to accidentally pin tabs.
QA Whiteboard: [qa-ver-needed-c145/b144][uplift]
QA Contact: rdoghi
| Assignee | ||
Comment 9•4 months ago
|
||
Updated•4 months ago
|
Attachment #9514986 -
Flags: approval-mozilla-release?
Comment 10•4 months ago
|
||
firefox-release Uplift Approval Request
- User impact if declined: Unintentional pinning when dragging to the start of the tabstrip with no pins.
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: Have no pinned tabs and try to move a tab to the first position.
- Risk associated with taking this patch: low
- Explanation of risk level: Just adds a pref and a delay to the interaction cue. No other behaviour impact.
- String changes made/needed: N/A
- Is Android affected?: no
Updated•4 months ago
|
Attachment #9514986 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Updated•4 months ago
|
Comment 11•4 months ago
|
||
| uplift | ||
Comment 12•4 months ago
|
||
Verified as fixed in our latest Release build 143.0.3
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-needed-c145/b144][uplift] → [qa-ver-done-c145/b144][uplift]
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•