1984210 - Drag-to-pin way too easy to trigger

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[leoholdiman7]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:143.0) Gecko/20100101 Firefox/143.0

Steps to reproduce:

I clicked the very left tab on my Firefox window, moving my cursor a small, unnoticeable amount while left clicking.

Actual results:

The very left tab pins itself, as if I right clicked and clicked "Pin Tab".

Expected results:

It should have just switched to that tab.

Comment 1

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=814d099b10c2fc60993cea8af697227e94cdd303&tochange=b9dd6650484e3485f0606a978708e451b781259f

Comment 2

[BugBot [:suhaib / :marco]]

:nsharpley, since you are the author of the regressor, bug 1963552, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[juraj.masiar]

Note that this new feature prevents you from moving any tab to the beginning of the tabs without pinning it.

Comment 4

[Sarah Clements [:sclements]]

Hi, did you see a highlighted icon when dragging? A video would really help us to understand how you're experiencing the issue, since this is a new feature.

Comment 5

[Alice0775 White]

Screencast: https://youtu.be/m7iLW7xIPKs

Comment 6

[leoholdiman7]

https://www.youtube.com/watch?v=bOeTkiXR0tQ
raw video file: https://drive.google.com/file/d/1tpsU3vDvAGSGBSguI3bLvS1nnb7JYZpJ/view?usp=sharing

Comment 7

[Dean Lafferty]

Please add ability to turn this unwanted feature off. Really annoying. Some users don't use pinned tabs at all.

Comment 8

[juraj.masiar]

Attachment: moving tabs near beginning pins tabs

Yet another video to better show what's happening, because it feels like a bug, not intended behavior.

Comment 9

[BugBot [:suhaib / :marco]]

The bug is marked as tracked for firefox143 (beta). However, the bug still isn't assigned and has low severity.

:cbellini, could you please find an assignee and increase the severity for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 10

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1984210 - Improve drag to pin sensitivity r=#tabbrowser-reviewers

• reduced the distance you need to drag the tab close enough to the edge of the tab strip by half
• introduced a 350ms delay before the transition
• fixed the issue where it was pinning when not quite hovering over the interaction cue.

Comment 11

[jpmhouston]

(In reply to Dean Lafferty from comment #7)

Please add ability to turn this unwanted feature off. Really annoying. Some users don't use pinned tabs at all.

Yes, this. It's not like you don't have space for more options in about:config!!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c0b1f5c79cea
https://hg.mozilla.org/integration/autoland/rev/d76429966df1
Improve drag to pin sensitivity r=tabbrowser-reviewers,sthompson

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d76429966df1

Comment 14

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:nsharpley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox143 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[Sarah Clements [:sclements]]

Hi leoholdiman7, Nikki's changes should be in Nightly now. Could you upgrade to the latest version and see if the behavior is improved?

Comment 16

[leoholdiman7]

Much better, much harder to accidentally pin a tab. 👍

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Is this ready for an uplift request?

Comment 18

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1984210 - Improve drag to pin sensitivity r=#tabbrowser-reviewers

• reduced the distance you need to drag the tab close enough to the edge of the tab strip by half
• introduced a 350ms delay before the transition
• fixed the issue where it was pinning when not quite hovering over the interaction cue.

Original Revision: https://phabricator.services.mozilla.com/D262141

Comment 19

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Too easy to accidentally pin tabs
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Try to drag a tab to the first position without pinning.
• Risk associated with taking this patch: Low
• Explanation of risk level: UI only
• String changes made/needed: N/A
• Is Android affected?: no

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/4260315e229a
https://hg.mozilla.org/releases/mozilla-beta/rev/08897cd5d669

Comment 21

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed in Nightly 144.0a1 and Firefox 143.0b9.