1989392 - Image preview in "Insert Image" dialog fails with CSP error when image is inserted from web resource

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Francesco]

Open a compose window and insert am image via the "Insert Image" dialog from a web resource, for example:
https://bugzilla.mozilla.org/images/index/firefox-beta.svg

Result: Image preview is broken.

Error in the console:
Content-Security-Policy: The page’s settings blocked the loading of a resource (img-src) at https://bugzilla.mozilla.org/images/index/firefox-beta.svg because it violates the following directive: “img-src chrome: data:” EdImageDialog.js:296:3

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1989392 - "Insert Image" dialog CSP needs to allow http/s. r=arschmitz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/04b9052114b6
"Insert Image" dialog CSP needs to allow http/s. r=arschmitz

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9514133 [details]
Bug 1989392 - "Insert Image" dialog CSP needs to allow http/s. r=arschmitz

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Broken feature
• User impact if declined: Preview doesn't work
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Confined change
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 4

[Corey Bryant]

Comment on attachment 9514133 [details]
Bug 1989392 - "Insert Image" dialog CSP needs to allow http/s. r=arschmitz

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 144.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/846156d45e44

Comment 6

[Corey Bryant]

Comment on attachment 9514133 [details]
Bug 1989392 - "Insert Image" dialog CSP needs to allow http/s. r=arschmitz

[Triage Comment]
Approved for esr140

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 140.4.0esr:
https://hg.mozilla.org/releases/comm-esr140/rev/cff647890450933bf0a02290682d4fc4c6923eb2