1989498 - [ews] EWS Folder Properties "Select this folder for offline use" doesn't work.

Status: RESOLVED FIXED

(MailNews Core :: Networking: Exchange, defect)

Description

[Ben Campbell]

Now that EWS folders have dome autosync support for downloading messages for offline, the folder properties dialog needs a little work.

i.e. right click on a folder, and select the "Properties" menu item.
Mainly the "Synchronisation" tab.
It currently seems to show the checkboxes and "Download Now" buttons for both IMAP and news.

Comment 1

[Toby Pilling [:tobyp]]

Is this a duplicate of bug 1989067?

Comment 2

[Ben Campbell]

(In reply to Toby Pilling [:tobyp] from comment #1)

Is this a duplicate of bug 1989067?

Yes.... although,

1. the "Select this folder for offline use" seems to be ignored (probably my fault that it's being ignored, but there should also be something somewhere to set an appropriate default (on for inbox, off for trash and junk etc...). Not sure where that happens for IMAP/News.
2. and the "download now" button just Asserts (Bug 1989500)

I think we can repurpose this bug for 1.

Comment 3

[Brendan Abolivier [:babolivier]]

Please use the correct product and component when filing Exchange bugs, otherwise they're quick to fall out of people's radar.

(In reply to Ben Campbell from comment #2)

(In reply to Toby Pilling [:tobyp] from comment #1)

Is this a duplicate of bug 1989067?

Yes.... although,

1. the "Select this folder for offline use" seems to be ignored (probably my fault that it's being ignored, but there should also be something somewhere to set an appropriate default (on for inbox, off for trash and junk etc...). Not sure where that happens for IMAP/News.
2. and the "download now" button just Asserts (Bug 1989500)

I think we can repurpose this bug for 1.

Agreed! I left these in because we had previously discussed that you would be looking into message download controls as part of bug 1986399 et al. Though if you think it'd be better to hide this setting until we're able to plug it in the right place, I'm happy to do so too.

Comment 4

[Ben Campbell]

(In reply to Brendan Abolivier [:babolivier] from comment #3)

Agreed! I left these in because we had previously discussed that you would be looking into message download controls as part of bug 1986399 et al. Though if you think it'd be better to hide this setting until we're able to plug it in the right place, I'm happy to do so too.

No, no, they should definitely be there. We just need to figure out how they're meant to work :-)

Comment 5

[Ben Campbell]

Attachment: Bug 1989498 - Inline and remove nsImapIncomingServer::CreateHostSpecificPrefName(). r=#thunderbird-back-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2dfde209423d
Inline and remove nsImapIncomingServer::CreateHostSpecificPrefName(). r=mkmelin

Comment 7

[Ben Campbell]

Attachment: Bug 1989498 - Wire up offline-message policy settings for EWS folders. r=#thunderbird-reviewers

Comment 8

[Brendan Abolivier [:babolivier]]

De-queueing out of concern regarding side effects I've noted on the patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/59a892814f8b
Wire up offline-message policy settings for EWS folders. r=mkmelin,babolivier

Comment 10

[Magnus Melin [:mkmelin]]

Backed out for test failures: https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=egJ1bqKuT36kGXBFoQRaHA.0
Backout: https://hg.mozilla.org/comm-central/rev/12f482656130fc2acc6f703158cee3f82aa97b6b

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/044739e795bd
Wire up offline-message policy settings for EWS folders. r=mkmelin,babolivier