1989632 - Make ConcurrentConnection properly thread-safe

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P2)

Description

[Marco Bonardo [:mak]]

ConcurrentConnection may be created off the main-thread, even just to register a pending request... While it uses thread-safe refcounting, it was not designed to be used like that, and thus some properties and initialization expect to be on the main-thread. Those should properly be dispatched.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1989632 - Make ConcurrentConnection properly thread-safe. r=Standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a653c1921332
https://hg.mozilla.org/integration/autoland/rev/7d5a302ca683
Make ConcurrentConnection properly thread-safe. r=Standard8,places-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3fa096bd62ae
https://hg.mozilla.org/integration/autoland/rev/bdb74d66642f
Revert "Bug 1989632 - Make ConcurrentConnection properly thread-safe. r=Standard8,places-reviewers" for causing bustages in test_ConcurrentConnection.cpp

Comment 4

[Atila Butkovits]

Backed out for causing bustages in test_ConcurrentConnection.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/bdb74d66642f

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d9d4df13d7490ed6fd62988460e832c800798e13&selectedTaskRun=G3XTJQw9S3KAY5HZa4ddqg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=562137510&repo=autoland&task=dlaOHvzZQQiKEKi5f1jb9g.0&lineNumber=126739

Comment 5

[Marco Bonardo [:mak]]

Of course, the only test that didn't run on Try

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/047172930281
https://hg.mozilla.org/integration/autoland/rev/552e480efcc8
Make ConcurrentConnection properly thread-safe. r=Standard8,places-reviewers

Comment 7

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/552e480efcc8