1990037 - Switch attribution kind to use from-deps

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

The attribution kind currently assumes that a build platform exists in the graph and independently derives a label for it and tries to access config.kind_dependencies_tasks[label]. This results in a KeyError if you happen to be using a weird parameters.yml where the builds end up getting skipped (aka parameters from a github-push).

These tasks should be using from-deps to automatically derive themselves only when the target platforms are actually being generated.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1990037 - [ci] Use 'from_deps' in attribution kinds, r?#taskgraph-reviewers

These were causing issues when generating graphs that don't have any
shippable builds in them, as they were deriving the parent labels and
assuming they exist in the graph. (A scenario that came up while I was
working on supporting Gecko CI in Github).

The preferred method to handle this is to instead derive the entire
tasks from only existing parents.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1990037 - [ci] Don't assume repackage/mar-signing deps exist in beetmover-repackage, r?bhearsum

I managed to get a graph where these were missing from upstream_deps
(using Github events). This patch helps unblock me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fff278691b8d
https://hg.mozilla.org/integration/autoland/rev/6ce3964293e7
[ci] Use 'from_deps' in attribution kinds, r=taskgraph-reviewers,releng-reviewers,bhearsum
https://github.com/mozilla-firefox/firefox/commit/34eeba4e5a4e
https://hg.mozilla.org/integration/autoland/rev/d8df33a6635d
[ci] Don't assume repackage/mar-signing deps exist in beetmover-repackage, r=bhearsum,taskgraph-reviewers,releng-reviewers

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/6ce3964293e7
https://hg.mozilla.org/mozilla-central/rev/d8df33a6635d