Closed
Bug 1990243
Opened 1 month ago
Closed 1 month ago
Migrate FocusTheme to Material3
Categories
(Focus :: General, task)
Tracking
(firefox145 fixed)
RESOLVED
FIXED
145 Branch
| Tracking | Status | |
|---|---|---|
| firefox145 | --- | fixed |
People
(Reporter: mcarare, Assigned: mcarare)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group6] )
Attachments
(1 file)
Also check current usages to prevent visual regressions.
Updated•1 month ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
Migrating FocusTheme, FocusTypography, etc has to be done in the same commit.
Summary: Migrate FocusTypography to Material3 → Migrate FocusTheme to Material3
| Assignee | ||
Comment 2•1 month ago
|
||
Key changes include:
- Updating theme and color definitions to use M3 components (
FocusTheme.kt,FocusColors.kt). This involves updating color palette functions (e.g.,darkColorstodarkColorScheme). - Updating typography definitions to align with M3 scale (
FocusTypography.kt). This involves replacing M2 typography styles (e.g.,body1) with their M3 counterparts (e.g.,bodyLarge). - Updating UI components that used the old M2 theme properties to use the new M3 properties (e.g., in
AboutFragment.ktandClickableSubstringLink.kt).
Updated•1 month ago
|
Attachment #9515039 -
Attachment description: Bug 1990243 - Migrate Focus to Material 3 (M3) → Bug 1990243 - Migrate FocusTheme to Material 3 (M3)
Pushed by mcarare@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/e50f5b319fe1
https://hg.mozilla.org/integration/autoland/rev/7bb4abbcdc4f
Migrate FocusTheme to Material 3 (M3) r=android-reviewers,avirvara
Comment 4•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox145:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•