1990434 - Wrong icon displayed in the Activity Manager when deleting a folder

Status: REOPENED

(Thunderbird :: Theme, defect)

Description

[vlakoff]

Attachment: The "Calendar" icon that is erroneously displayed in the Activity Manager

Steps to reproduce:

Delete some folder (i.e. move it to the Trash).

Actual results:

In the Activity Manager, there is an entry "Moved folder <name> to Trash", but it has a "Calendar" icon, which is completely unrelated.

Reproduced on Thunderbird 128 (ESR), 140 (ESR), and 143.

Expected results:

It should have a correct icon, namely a combination of a folder and a recycle bin, to correctly represent the action.

Comment 1

[Ramona Gavrilescu]

Attachment: old icon moved folder in activity manager.png

Comment 2

[Ramona Gavrilescu]

Hello,

I checked this issue and it is as the reported stated, when a folder is moved to Trash on the activity manger, a calendar icon is displayed.
However the “calendar” icon is displayed only when the folder is moved to trash, after the folder is deleted the bin icon is displayed.(check screenshots attached)
I don’t think this is a regression as I checked on TB 91.13.1 and a similar icon was displayed.(check screenshot attached).

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 1990434 - Cleanup the Activity icons. r=#thunderbird-front-end-reviewers

Comment 4

[vlakoff]

Replying to this comment on Phabricator:

I changed the icon to the gear wheel instead of the calendar icon. The old icon with the clock matched more to this activity. Or should the icon be updated? If not, should defaultEventIcon.svg be deleted as it is no more used?

I don't think the "gear icon" would fit well. Rather than a "default" icon, to me it sounds more like a "settings" icon…

Ideally, a new icon could be created: a combination of a folder and a recycle bin. But maybe it would be "too many shapes" for a small icon. Also, maybe you wouldn't be motivated to create a new icon.

But, don't we just have a "recycle bin" icon somewhere? That would probably be good enough.

---

On a related note, I'm encountering a lot of errors on the Phabricator page, like this one:

Unhandled Exception ("Exception")
Failed to load file data for changeset ("PHID-FILE-653utkplr54b6pueaao2").

That seems to be related to the deleted files, which are stuck in a "Loading..." state.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6b238d4f6402
Cleanup the Activity icons. r=aleca

Comment 6

[vlakoff]

It's quite impressive that so many icons were left over—any idea what might explain that?

Comment 7

[vlakoff]

Mmm, there's a deleteMailIcon.svg that was already baked in and is practically begging to be used.
It would be a much, much better pick than the "gear wheel" icon.

Comment 8

[vlakoff]

I initially reported a simple icon mismatch — just a matter of replacing one icon with another. Somehow, that turned into a full-blown icon cleanup effort that had little to do with the actual issue.

Ironically, using the correct icon — which was already available — ended up being the one thing that didn't happen.

As for the Activity Manager supposedly being replaced someday (as mentioned on Phabricator)… well, that's great in theory, but until it actually happens, it's still here — so let's fix what's in front of us.