1990552 - Add extension controlled annotation to the redesigned proxy settings section

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Benjamin VanderSloot [:bvandersloot]]

This was omitted from the config-based conversion in the legacy page because there is not a disable-able control to attach the warning to and the existing design replaces a description with this warning, making for UI weirdness.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1990552 - Use setting-control's extension controlled message for Network settings r?bvandersloot

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/10a499686de5
https://hg.mozilla.org/integration/autoland/rev/998233abe5b5
Use setting-control's extension controlled message for Network settings r=bvandersloot,mconley

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing several failures.

Push with failures

Failure logs:

• TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/chrome/test_setting_group.html | First child is a fieldset - got "moz-card", expected "moz-fieldset" - https://treeherder.mozilla.org/logviewer?job_id=542674205&repo=autoland&task=To9pfs9nTsOQevagssX5sw.0
• TEST-UNEXPECTED-FAIL | browser/tools/mozscreenshots/preferences/browser_preferences.js | capture - Unexpected exception in [ prefsGeneral-browsingGroup ]: TypeError: can't access property "scrollIntoView" - https://treeherder.mozilla.org/logviewer?job_id=542680506&repo=autoland&task=AyRFsgu6ShSZTBMZWs7AjA.0
• TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_storagePressure_notification.js - Element should not be null, when checking visibility - https://treeherder.mozilla.org/logviewer?job_id=542675018&repo=autoland&task=dh94aMWxTN6FT9KELcXTVA.0
• also this TV - https://treeherder.mozilla.org/logviewer?job_id=542674169&repo=autoland&task=XkhzfCiHSC-Nm6J33QWSjg.0

Backout link

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/998233abe5b5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7d1b5f8680b8
https://hg.mozilla.org/integration/autoland/rev/17c54be67f4b
Use setting-control's extension controlled message for Network settings r=bvandersloot,mconley

Comment 6

[Cristina Horotan [:chorotan]]

Backed out for causing ESlint failure and bc failures

Backout link

Push with failures

Failure log
Failure log bc
Failure log ss

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/17c54be67f4b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aede87d3ddfb
https://hg.mozilla.org/integration/autoland/rev/4809436a75b1
Use setting-control's extension controlled message for Network settings r=bvandersloot,mconley

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4809436a75b1