1994888 - Always use setting-group for group headings

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

We generally have groupbox elements handling the headings still. This started due to some sections needing an h1 instead of an h2, and we currently have an issue from bug 1993571 where sections could accidentally be shown when they shouldn't be without a groupbox.

We could work around the h1/h2 issue by having the setting-group always render an h2 if its on paneSearchResults

While we're at it, the setting-group itself will need to have the bottom margin added like we do for other [data-category] groups https://searchfox.org/firefox-main/rev/f8a53e9a2f08aafc12e8cc4c4d77c17f0ff0307c/browser/themes/shared/preferences/preferences.css#73-76

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1994888 - Part 1: Use SettingGroupManager/initSettingGroup in FormAutofillPreferences r?mtigley

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1994888 - Part 2: Move headings out of groupboxes and use setting-group instead r?#settings-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/744093820257
https://hg.mozilla.org/integration/autoland/rev/ba79911a4eee
Part 1: Use SettingGroupManager/initSettingGroup in FormAutofillPreferences r=mtigley,credential-management-reviewers,dimi
https://github.com/mozilla-firefox/firefox/commit/232959e51209
https://hg.mozilla.org/integration/autoland/rev/0627385a0aa0
Part 2: Move headings out of groupboxes and use setting-group instead r=fluent-reviewers,desktop-theme-reviewers,credential-management-reviewers,mconley,dimi,bolsson,hjones

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing several failures.

Push with failures

Failure logs:

• TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/chrome/test_setting_group.html | First child is a fieldset - got "moz-card", expected "moz-fieldset" - https://treeherder.mozilla.org/logviewer?job_id=542674205&repo=autoland&task=To9pfs9nTsOQevagssX5sw.0
• TEST-UNEXPECTED-FAIL | browser/tools/mozscreenshots/preferences/browser_preferences.js | capture - Unexpected exception in [ prefsGeneral-browsingGroup ]: TypeError: can't access property "scrollIntoView" - https://treeherder.mozilla.org/logviewer?job_id=542680506&repo=autoland&task=AyRFsgu6ShSZTBMZWs7AjA.0
• TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_storagePressure_notification.js - Element should not be null, when checking visibility - https://treeherder.mozilla.org/logviewer?job_id=542675018&repo=autoland&task=dh94aMWxTN6FT9KELcXTVA.0
• also this TV - https://treeherder.mozilla.org/logviewer?job_id=542674169&repo=autoland&task=XkhzfCiHSC-Nm6J33QWSjg.0

Backout link

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ba79911a4eee
https://hg.mozilla.org/mozilla-central/rev/0627385a0aa0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b3947163c97
https://hg.mozilla.org/integration/autoland/rev/a3d8c52caa57
Part 1: Use SettingGroupManager/initSettingGroup in FormAutofillPreferences r=mtigley,credential-management-reviewers,dimi
https://github.com/mozilla-firefox/firefox/commit/dc82e68e5b77
https://hg.mozilla.org/integration/autoland/rev/66358aff94bc
Part 2: Move headings out of groupboxes and use setting-group instead r=fluent-reviewers,desktop-theme-reviewers,credential-management-reviewers,mconley,dimi,bolsson,hjones

Comment 7

[Cristina Horotan [:chorotan]]

Backed out for causing ESlint failure and bc failures

Backout link

Push with failures

Failure log
Failure log bc
Failure log ss

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a3d8c52caa57
https://hg.mozilla.org/mozilla-central/rev/66358aff94bc

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2986ab0622ce
https://hg.mozilla.org/integration/autoland/rev/34eb338554a5
Part 1: Use SettingGroupManager/initSettingGroup in FormAutofillPreferences r=mtigley,credential-management-reviewers,dimi
https://github.com/mozilla-firefox/firefox/commit/631f8778ae9a
https://hg.mozilla.org/integration/autoland/rev/3d5c9d7783d2
Part 2: Move headings out of groupboxes and use setting-group instead r=fluent-reviewers,desktop-theme-reviewers,credential-management-reviewers,mconley,dimi,bolsson,hjones

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/34eb338554a5
https://hg.mozilla.org/mozilla-central/rev/3d5c9d7783d2