1991104 - Add support for a message slot to moz-message-bar

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Hanna Jones [:hjones]]

In the course of the SRD work we've run into a couple instances where designs call for a link embedded in the middle of moz-message-bar text. Although seemingly simple, this is not possible with the current moz-message-bar implementation, since it only supports string message or messageL10nId, but in the latter case we can't use data-l10n-name. To get around this we should add support for a message slot.

Once the slot is added we can assess if it's worth deprecating support for messageL10nId and messageL10nArgs.

This work should also cover ensuring we add documentation to both Storybook and the Acorn site.

Comment 1

[Hanna Jones [:hjones]]

here's a specific example from the about:preferences mockups: https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=6822-11912&m=dev

I think we also wanted to use a moz-message-bar for the windows-launch-on-login-disabled message, but went with a moz-box-item instead because it's more flexible. We should switch that to a moz-message-bar once we support this slot.

Comment 2

[Hanna Jones [:hjones]]

Just a note that as part of this work we should switch this element from moz-box-item to moz-message-bar. I think it was originally supposed to be a moz-message-bar, but we switched it because of the link limitation. It can be a second patch on the stack.

Comment 3

[Mark Kennedy [:mark]]

Attachment: Bug 1991104 - Add support for a message slot to moz-message-bar r=#reusable-components-reviewers-rotation

Comment 4

[Mark Kennedy [:mark]]

Attachment: Bug 1991104 - Update and consolidate message-related types in moz-message-bar r=#reusable-components-reviewers-rotation

Comment 5

[Mark Kennedy [:mark]]

Attachment: Bug 1991104 - Update windows-launch-on-login-disabled setting to moz-message-bar r=#reusable-components-reviewers-rotation

Comment 6

[Phabricator Automation]

Comment on attachment 9519239 [details]
Bug 1991104 - Update and consolidate message-related types in moz-message-bar r=#reusable-components-reviewers-rotation

Revision D268134 was moved to bug 1994819. Setting attachment 9519239 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8624a4b819f7
https://hg.mozilla.org/integration/autoland/rev/a33189a30774
Add support for a message slot to moz-message-bar r=hjones

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a33189a30774

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/35362df915a1
https://hg.mozilla.org/integration/autoland/rev/b9b1e2d91708
Update and consolidate message-related types in moz-message-bar r=mstriemer

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b9b1e2d91708

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa23d591bc30
https://hg.mozilla.org/integration/autoland/rev/f3c03816d078
Update windows-launch-on-login-disabled setting to moz-message-bar r=mstriemer

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f3c03816d078